From: Mel Gorman <mgorman@techsingularity.net>
To: Valentin Schneider <valentin.schneider@arm.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>
Subject: Re: [PATCH] sched/fair: Fix unused prototype warning
Date: Wed, 26 Feb 2020 15:07:23 +0000 [thread overview]
Message-ID: <20200226150723.GD3818@techsingularity.net> (raw)
In-Reply-To: <20200226121244.7524-1-valentin.schneider@arm.com>
On Wed, Feb 26, 2020 at 12:12:44PM +0000, Valentin Schneider wrote:
> Building against the latest tip/sched/core
>
> a0f03b617c3b ("sched/numa: Stop an exhastive search if a reasonable swap candidate or idle CPU is found")
>
> with the arm64 defconfig (which doesn't have CONFIG_SCHED_SMT set) leads
> to:
>
> kernel/sched/fair.c:1525:20: warning: ???test_idle_cores??? declared ???static??? but never defined [-Wunused-function]
> static inline bool test_idle_cores(int cpu, bool def);
> ^~~~~~~~~~~~~~~
>
> Rather than define it in its own CONFIG_SCHED_SMT #define island, bunch it
> up with test_idle_cores().
>
> Signed-off-by: Valentin Schneider <valentin.schneider@arm.com>
Acked-by: Mel Gorman <mgorman@techsingularity.net>
Ingo, what is your preferred method for dealing with this situation
in tip? A resubmission of "sched/numa: Stop an exhastive search if a
reasonable swap candidate or idle CPU is found" with these folded together
or Valentin's patch on top?
--
Mel Gorman
SUSE Labs
prev parent reply other threads:[~2020-02-26 15:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 12:12 [PATCH] sched/fair: Fix unused prototype warning Valentin Schneider
2020-02-26 15:07 ` Mel Gorman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200226150723.GD3818@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox