From: Mark Brown <broonie@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Jon Hunter <jonathanh@nvidia.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH] regulator: pwm: Don't warn on probe deferral
Date: Wed, 26 Feb 2020 16:39:05 +0000 [thread overview]
Message-ID: <20200226163905.GH4136@sirena.org.uk> (raw)
In-Reply-To: <20200226161757.idpzbs3jmayt7ya6@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 837 bytes --]
On Wed, Feb 26, 2020 at 05:17:57PM +0100, Uwe Kleine-König wrote:
> On Mon, Feb 24, 2020 at 04:58:59PM +0000, Mark Brown wrote:
> > This then means that there's no way for users to determine why the
> > driver has failed to instantiate which can be frustrating. It'd be
> > better to at least have some dev_dbg() output when deferring so that
> > there's something for people to go on without having to instrument the
> > code.
> Not printing an error message is quite usual however. I think a generic
Usual yet also frustraing.
> approach that for example makes the list of devices that should be
> retried to probe on the next opportunity inspectable would be nice.
That's not really the issue, the bigger issue is trying to figure out
why things are stuck - what exactly caused things to fail to
instantiate.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-02-26 16:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 14:40 [PATCH] regulator: pwm: Don't warn on probe deferral Jon Hunter
2020-02-24 15:12 ` Thierry Reding
2020-02-24 16:58 ` Mark Brown
2020-02-26 16:17 ` Uwe Kleine-König
2020-02-26 16:39 ` Mark Brown [this message]
2020-03-06 7:51 ` Uwe Kleine-König
2020-03-06 12:35 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200226163905.GH4136@sirena.org.uk \
--to=broonie@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox