From: Lee Jones <lee.jones@linaro.org>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
b.galvani@gmail.com, linus.walleij@linaro.org,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
phh@phh.me, stefan@agner.ch, letux-kernel@openphoenux.org,
jic23@kernel.org
Subject: Re: [PATCH v5 1/2] mfd: rn5t618: add ADC subdevice for RC5T619
Date: Wed, 26 Feb 2020 17:46:40 +0000 [thread overview]
Message-ID: <20200226174640.GR3494@dell> (raw)
In-Reply-To: <20200226174914.047667d5@kemnade.info>
On Wed, 26 Feb 2020, Andreas Kemnade wrote:
> On Wed, 26 Feb 2020 15:40:55 +0000
> Lee Jones <lee.jones@linaro.org> wrote:
>
> > On Sun, 23 Feb 2020, Andreas Kemnade wrote:
> >
> > > This adds a subdevice for the ADC in the RC5T619
> > >
> > > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> > > ---
> > > depends on:
> > > https://lore.kernel.org/lkml/20191220122416.31881-1-andreas@kemnade.info/
> > >
> > > Changes in v3:
> > > re-added it to the series because of
> > > "Oh, it looks like there was a conflict. Could you collect any Acks
> > > (including mine) rebase and resend please?"
> >
> > Looks like there is still a conflict. Sure, it's not a complicated
> > fix, but that's beside the point. What tree is this set based on?
> >
> It must be applied on top of my rc5t619 rtc series here:
> https://lore.kernel.org/lkml/20191220122416.31881-1-andreas@kemnade.info/
>
> I expected it to make it into 5.6 and when I first sent the RTC series
> (in October) I had no idea when I will continue with other stuff.
>
> That is why I sent this ADC series separately, also to give the IIO
> maintainer plenty of time to review.
If a patch-set can or should be applied on its own, you should send it
based on an upstream commit, or else things like this happen.
My advice would be to maintain topic branches, each based on an
upstream release, which you can merge together into an integration
branch for full coverage testing.
> Do you want me to resend all that pending stuff together in one series?
> I have little experience with this multi-subdevice process.
It makes more sense to rebase this set onto the latest full release
and resubmit this set on its own.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2020-02-26 17:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-23 13:16 [PATCH v5 0/2] mfd: rn5t618: add ADC support Andreas Kemnade
2020-02-23 13:16 ` [PATCH v5 1/2] mfd: rn5t618: add ADC subdevice for RC5T619 Andreas Kemnade
2020-02-26 15:40 ` Lee Jones
2020-02-26 16:49 ` Andreas Kemnade
2020-02-26 17:46 ` Lee Jones [this message]
2020-02-26 18:11 ` Andreas Kemnade
2020-02-27 9:40 ` Lee Jones
2020-02-27 11:56 ` Andreas Kemnade
2020-02-23 13:16 ` [PATCH v5 2/2] iio: adc: rn5t618: Add ADC driver for RN5T618/RC5T619 Andreas Kemnade
2020-02-26 19:27 ` Andreas Kemnade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200226174640.GR3494@dell \
--to=lee.jones@linaro.org \
--cc=andreas@kemnade.info \
--cc=b.galvani@gmail.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=letux-kernel@openphoenux.org \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phh@phh.me \
--cc=pmeerw@pmeerw.net \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox