Re: [PATCH v1 3/5] efi/arm: Start using fw_devlink_get_flags()

Ard Biesheuvel
2020-02-22T07:37:48Z

On Sat, 22 Feb 2020 at 02:40, Saravana Kannan <saravanak@google.com> wrote:
>
> The fw_devlink_get_flags() provides the right flags to use when creating
> mandatory device links derived from information provided by the
> firmware. So, use that.
>
> Signed-off-by: Saravana Kannan <saravanak@google.com>
> ---

Acked-by: Ard Biesheuvel <ardb@kernel.org>

> drivers/firmware/efi/arm-init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/efi/arm-init.c b/drivers/firmware/efi/arm-init.c
> index d99f5b0c8a09..6703bedfa9e1 100644
> --- a/drivers/firmware/efi/arm-init.c
> +++ b/drivers/firmware/efi/arm-init.c
> @@ -349,7 +349,7 @@ static int efifb_add_links(const struct fwnode_handle *fwnode,
> * If this fails, retrying this function at a later point won't
> * change anything. So, don't return an error after this.
> */
> - if (!device_link_add(dev, sup_dev, 0))
> + if (!device_link_add(dev, sup_dev, fw_devlink_get_flags()))
> dev_warn(dev, "device_link_add() failed\n");
>
> put_device(sup_dev);
> --
> 2.25.0.265.gbab2e86ba0-goog
>