From: Stafford Horne <shorne@gmail.com>
To: LKML <linux-kernel@vger.kernel.org>,
Openrisc <openrisc@lists.librecores.org>
Cc: Stafford Horne <shorne@gmail.com>,
Jonas Bonn <jonas@southpole.se>,
Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
Christian Brauner <christian@brauner.io>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Allison Randal <allison@lohutok.net>
Subject: [PATCH 3/3] openrisc: Cleanup copy_thread_tls docs and comments
Date: Thu, 27 Feb 2020 07:56:25 +0900 [thread overview]
Message-ID: <20200226225625.28935-4-shorne@gmail.com> (raw)
In-Reply-To: <20200226225625.28935-1-shorne@gmail.com>
Previously copy_thread_tls was copy_thread and before that something
else. Remove the documentation about the regs parameter that didn't
exist in either version.
Next, fix comment wrapping and details about how TLS pointer gets to the
copy_thread_tls function.
Signed-off-by: Stafford Horne <shorne@gmail.com>
---
arch/openrisc/kernel/process.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/openrisc/kernel/process.c b/arch/openrisc/kernel/process.c
index 6695f167e126..b442e7b59e17 100644
--- a/arch/openrisc/kernel/process.c
+++ b/arch/openrisc/kernel/process.c
@@ -122,7 +122,6 @@ extern asmlinkage void ret_from_fork(void);
* @usp: user stack pointer or fn for kernel thread
* @arg: arg to fn for kernel thread; always NULL for userspace thread
* @p: the newly created task
- * @regs: CPU context to copy for userspace thread; always NULL for kthread
* @tls: the Thread Local Storate pointer for the new process
*
* At the top of a newly initialized kernel stack are two stacked pt_reg
@@ -180,7 +179,8 @@ copy_thread_tls(unsigned long clone_flags, unsigned long usp,
userregs->sp = usp;
/*
- * For CLONE_SETTLS set "tp" (r10) to the TLS pointer passed to sys_clone.
+ * For CLONE_SETTLS set "tp" (r10) to the TLS pointer passed
+ * in clone_args to sys_clone3.
*/
if (clone_flags & CLONE_SETTLS)
userregs->gpr[10] = tls;
--
2.21.0
next prev parent reply other threads:[~2020-02-26 22:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 22:56 [PATCH 0/3] OpenRISC clone3 support Stafford Horne
2020-02-26 22:56 ` [PATCH 1/3] openrisc: Convert copy_thread to copy_thread_tls Stafford Horne
2020-02-27 0:31 ` Stafford Horne
2020-02-27 12:19 ` Christian Brauner
2020-02-27 13:16 ` Stafford Horne
2020-02-26 22:56 ` [PATCH 2/3] openrisc: Enable the clone3 syscall Stafford Horne
2020-02-27 12:21 ` Christian Brauner
2020-02-27 13:29 ` Stafford Horne
2020-02-26 22:56 ` Stafford Horne [this message]
2020-02-27 12:24 ` [PATCH 3/3] openrisc: Cleanup copy_thread_tls docs and comments Christian Brauner
2020-02-27 12:26 ` [PATCH 0/3] OpenRISC clone3 support Christian Brauner
2020-02-27 13:18 ` Stafford Horne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200226225625.28935-4-shorne@gmail.com \
--to=shorne@gmail.com \
--cc=allison@lohutok.net \
--cc=christian@brauner.io \
--cc=gregkh@linuxfoundation.org \
--cc=jonas@southpole.se \
--cc=linux-kernel@vger.kernel.org \
--cc=openrisc@lists.librecores.org \
--cc=stefan.kristiansson@saunalahti.fi \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox