From: Jin Yao <yao.jin@linux.intel.com>
To: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
mingo@redhat.com, alexander.shishkin@linux.intel.com
Cc: Linux-kernel@vger.kernel.org, ak@linux.intel.com,
kan.liang@intel.com, yao.jin@intel.com,
Jin Yao <yao.jin@linux.intel.com>
Subject: [PATCH v5 0/3] perf report: Support annotation of code without symbols
Date: Thu, 27 Feb 2020 12:39:36 +0800 [thread overview]
Message-ID: <20200227043939.4403-1-yao.jin@linux.intel.com> (raw)
For perf report on stripped binaries it is currently impossible to do
annotation. The annotation state is all tied to symbols, but there are
either no symbols, or symbols are not covering all the code.
We should support the annotation functionality even without symbols.
The first patch uses al_addr to print because it's easy to dump
the instructions from this address in binary for branch mode.
The second patch supports the annotation on stripped binary.
The third patch supports the hotkey 'a' on address for annotation.
v5:
---
Separate the hotkey 'a' implementation to a new patch
"perf report: Support hotkey 'a' on address for annotation"
v4:
---
1. Support the hotkey 'a'. When we press 'a' on address,
now it supports the annotation.
2. Change the patch title from
"Support interactive annotation of code without symbols" to
"perf report: Support interactive annotation of code without symbols"
v3:
---
Keep just the ANNOTATION_DUMMY_LEN, and remove the
opts->annotate_dummy_len since it's the "maybe in future
we will provide" feature.
v2:
---
Fix a crash issue when annotating an address in "unknown" object.
Jin Yao (3):
perf util: Print al_addr when symbol is not found
perf report: Support interactive annotation of code without symbols
perf report: Support hotkey 'a' on address for annotation
tools/perf/ui/browsers/hists.c | 90 +++++++++++++++++++++++++++-------
tools/perf/util/annotate.h | 1 +
tools/perf/util/sort.c | 6 ++-
3 files changed, 78 insertions(+), 19 deletions(-)
--
2.17.1
next reply other threads:[~2020-02-27 4:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 4:39 Jin Yao [this message]
2020-02-27 4:39 ` [PATCH v5 1/3] perf util: Print al_addr when symbol is not found Jin Yao
2020-04-04 8:42 ` [tip: perf/urgent] perf report: " tip-bot2 for Jin Yao
2020-02-27 4:39 ` [PATCH v5 2/3] perf report: Support interactive annotation of code without symbols Jin Yao
2020-03-18 15:42 ` Arnaldo Carvalho de Melo
2020-03-18 15:43 ` Arnaldo Carvalho de Melo
2020-03-18 15:46 ` Arnaldo Carvalho de Melo
2020-03-19 1:11 ` Jin, Yao
2020-03-19 0:56 ` Jin, Yao
2020-03-19 0:49 ` Jin, Yao
2020-04-04 8:42 ` [tip: perf/urgent] " tip-bot2 for Jin Yao
2020-02-27 4:39 ` [PATCH v5 3/3] perf report: Support hotkey 'a' on address for annotation Jin Yao
2020-04-04 8:42 ` [tip: perf/urgent] perf report/top TUI: Support hotkey 'a' for annotation of unresolved addresses tip-bot2 for Jin Yao
2020-03-02 4:08 ` [PATCH v5 0/3] perf report: Support annotation of code without symbols Ravi Bangoria
2020-03-02 12:51 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200227043939.4403-1-yao.jin@linux.intel.com \
--to=yao.jin@linux.intel.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox