From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Yue Hu <zbestahu@gmail.com>
Cc: minchan@kernel.org, ngupta@vflare.org,
sergey.senozhatsky.work@gmail.com, axboe@kernel.dk,
linux-kernel@vger.kernel.org, huyue2@yulong.com,
zbestahu@163.com
Subject: Re: [PATCH] drivers/block/zram/zram_drv.c: avoid needless checks in backing_dev_store() failure path
Date: Thu, 27 Feb 2020 17:18:14 +0900 [thread overview]
Message-ID: <20200227081814.GI122464@google.com> (raw)
In-Reply-To: <20200227081219.13144-1-zbestahu@gmail.com>
On (20/02/27 16:12), Yue Hu wrote:
>
> There are null pointer checks in out block if backing_dev_store() fails.
> That is needless, we can avoid them by setting different jumping label.
>
Dunno. Numerous error-out labels to jump to (instead of a single one)
don't really look like an improvement to me.
-ss
prev parent reply other threads:[~2020-02-27 8:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 8:12 [PATCH] drivers/block/zram/zram_drv.c: avoid needless checks in backing_dev_store() failure path Yue Hu
2020-02-27 8:18 ` Sergey Senozhatsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200227081814.GI122464@google.com \
--to=sergey.senozhatsky.work@gmail.com \
--cc=axboe@kernel.dk \
--cc=huyue2@yulong.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=zbestahu@163.com \
--cc=zbestahu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox