Re: [PATCH 06/18] m68k: Replace setup_irq() by request_irq()

afzal mohammed
2020-02-13T02:03:35Z

Hi,

On Thu, Feb 13, 2020 at 09:25:19AM +1100, Finn Thain wrote:

> > - setup_irq(TMR_IRQ_NUM, &m68328_timer_irq);
> > + if (request_irq(TMR_IRQ_NUM, hw_tick, IRQF_TIMER, "timer", NULL))
> > + pr_err("request_irq() on %s failed\n", "timer");
>
> "request_irq() on timer failed" is bad grammar and doesn't convey what
> went wrong. It could be taken to mean that request_irq() was called
> because a timer went off.
>
> Have you considered,
>
> pr_err("%s: request_irq() failed\n", "timer");

i was uncomfortable with the string contents, since that didn't seem
nonsense and to avoid pondering time over it, it was used.

Your suggestion is definitely better, will use that instead.

Regards
afzal