From: George Wilson <gcwilson@linux.ibm.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: linux-integrity@vger.kernel.org,
Alexey Kardashevskiy <aik@ozlabs.ru>,
Stefan Berger <stefanb@linux.ibm.com>,
Nayna Jain <nayna@linux.vnet.ibm.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
linux-kernel@vger.kernel.org, Linh Pham <phaml@us.ibm.com>
Subject: Re: [PATCH] tpm: ibmvtpm: retry on H_CLOSED in tpm_ibmvtpm_send()
Date: Thu, 27 Feb 2020 10:40:46 -0600 [thread overview]
Message-ID: <20200227164046.GA1936@us.ibm.com> (raw)
In-Reply-To: <20200227162339.GF5140@linux.intel.com>
On Thu, Feb 27, 2020 at 06:23:39PM +0200, Jarkko Sakkinen wrote:
> On Thu, Feb 27, 2020 at 10:50:03AM -0500, George Wilson wrote:
> > tpm_ibmvtpm_send() can fail during LPM resume with an H_CLOSED return
> > from ibmvtpm_send_crq(). The PAPR says, 'The “partner partition
> > suspended” transport event disables the associated CRQ such that any
> > H_SEND_CRQ hcall() to the associated CRQ returns H_Closed until the CRQ
> > has been explicitly enabled using the H_ENABLE_CRQ hcall.' This patch
> > adds a check in tpm_ibmvtpm_send() for an H_CLOSED return from
> > ibmvtpm_send_crq() and in that case calls tpm_ibmvtpm_resume() and
> > retries the ibmvtpm_send_crq() once.
> >
> > Reported-by: Linh Pham <phaml@us.ibm.com>
> > Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
> > Signed-off-by: George Wilson <gcwilson@linux.ibm.com>
>
> What is LPM anyway?
It's PowerVM Live Partition Mobility.
>
> /Jarkko
--
George Wilson
IBM Linux Technology Center
Security Development
prev parent reply other threads:[~2020-02-27 16:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 15:50 [PATCH] tpm: ibmvtpm: retry on H_CLOSED in tpm_ibmvtpm_send() George Wilson
2020-02-27 16:23 ` Jarkko Sakkinen
2020-02-27 16:40 ` George Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200227164046.GA1936@us.ibm.com \
--to=gcwilson@linux.ibm.com \
--cc=aik@ozlabs.ru \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nayna@linux.vnet.ibm.com \
--cc=phaml@us.ibm.com \
--cc=stefanb@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox