From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B3FEC11D3D for ; Thu, 27 Feb 2020 17:59:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 460AD246A1 for ; Thu, 27 Feb 2020 17:59:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582826347; bh=yuxtO3e/a768sMDv+0KsbT2pPeVNtHRCp8kO9r0yIco=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=VH4h4vsSDYtgYOciPr6bjC9Vt2d6D9hukkBQHcWnGiC+xdomqMPNk25QAeMMgwbVj GkrM906L73FOrWs35Xxu1mynQr/Ek7kfZj6gc6+pZFiGKVkvcp815wiN1SJSsCauC8 g+sb1/NHDDFcuhkwDPM4r/lq2kcmSg69+lJDDPgw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730391AbgB0R7G (ORCPT ); Thu, 27 Feb 2020 12:59:06 -0500 Received: from mail.kernel.org ([198.145.29.99]:59202 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729859AbgB0R7G (ORCPT ); Thu, 27 Feb 2020 12:59:06 -0500 Received: from localhost (unknown [104.132.1.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BCB65246A3; Thu, 27 Feb 2020 17:59:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582826344; bh=yuxtO3e/a768sMDv+0KsbT2pPeVNtHRCp8kO9r0yIco=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DFkAvsxqy1V/ZWShlgqlvikVPya1vUke31kyn5q1UbLlHAZsz5+db0hNRYbsBZxmQ gLo813UATdkWf9cjFbnIzh1bpxxYgR+RrF2oljFdUVD8sMb29ahZY6sEECxxPHHQwj WXLaFbxLqDdGBaFMjLS/1u2nIdA/8z0BuZo2bVJE= Date: Thu, 27 Feb 2020 09:59:04 -0800 From: Jaegeuk Kim To: Chao Yu Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH] f2fs: show mounted time Message-ID: <20200227175904.GA33965@google.com> References: <20200226164615.170424-1-jaegeuk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/27, Chao Yu wrote: > On 2020/2/27 0:46, Jaegeuk Kim wrote: > > Let's show mounted time. > > > > Signed-off-by: Jaegeuk Kim > > --- > > Documentation/ABI/testing/sysfs-fs-f2fs | 5 +++++ > > fs/f2fs/debug.c | 3 +++ > > fs/f2fs/segment.c | 2 +- > > fs/f2fs/segment.h | 2 +- > > fs/f2fs/sysfs.c | 8 ++++++++ > > 5 files changed, 18 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/ABI/testing/sysfs-fs-f2fs b/Documentation/ABI/testing/sysfs-fs-f2fs > > index 1a6cd5397129..ddee45e88270 100644 > > --- a/Documentation/ABI/testing/sysfs-fs-f2fs > > +++ b/Documentation/ABI/testing/sysfs-fs-f2fs > > @@ -318,3 +318,8 @@ Date: September 2019 > > Contact: "Hridya Valsaraju" > > Description: Average number of valid blocks. > > Available when CONFIG_F2FS_STAT_FS=y. > > + > > +What: /sys/fs/f2fs//mounted_time > > +Date: February 2020 > > +Contact: "Jaegeuk Kim" > > +Description: Show the mounted time of this partition. > > It's better to describe its unit: second, otherwise, it looks good to me. I've added it. Thanks. > > Reviewed-by: Chao Yu > > Thanks, > > > diff --git a/fs/f2fs/debug.c b/fs/f2fs/debug.c > > index 6b89eae5e4ca..a8cf9626f71f 100644 > > --- a/fs/f2fs/debug.c > > +++ b/fs/f2fs/debug.c > > @@ -301,6 +301,9 @@ static int stat_show(struct seq_file *s, void *v) > > si->ssa_area_segs, si->main_area_segs); > > seq_printf(s, "(OverProv:%d Resv:%d)]\n\n", > > si->overp_segs, si->rsvd_segs); > > + seq_printf(s, "Current Time: %llu s / Mounted Time: %llu s\n\n", > > + ktime_get_boottime_seconds(), > > + SIT_I(si->sbi)->mounted_time); > > if (test_opt(si->sbi, DISCARD)) > > seq_printf(s, "Utilization: %u%% (%u valid blocks, %u discard blocks)\n", > > si->utilization, si->valid_count, si->discard_blks); > > diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c > > index fb3e531a36d2..601d67e72c50 100644 > > --- a/fs/f2fs/segment.c > > +++ b/fs/f2fs/segment.c > > @@ -4073,7 +4073,7 @@ static int build_sit_info(struct f2fs_sb_info *sbi) > > sit_i->dirty_sentries = 0; > > sit_i->sents_per_block = SIT_ENTRY_PER_BLOCK; > > sit_i->elapsed_time = le64_to_cpu(sbi->ckpt->elapsed_time); > > - sit_i->mounted_time = ktime_get_real_seconds(); > > + sit_i->mounted_time = ktime_get_boottime_seconds(); > > init_rwsem(&sit_i->sentry_lock); > > return 0; > > } > > diff --git a/fs/f2fs/segment.h b/fs/f2fs/segment.h > > index 459dc3901a57..7a83bd530812 100644 > > --- a/fs/f2fs/segment.h > > +++ b/fs/f2fs/segment.h > > @@ -756,7 +756,7 @@ static inline unsigned long long get_mtime(struct f2fs_sb_info *sbi, > > bool base_time) > > { > > struct sit_info *sit_i = SIT_I(sbi); > > - time64_t diff, now = ktime_get_real_seconds(); > > + time64_t diff, now = ktime_get_boottime_seconds(); > > > > if (now >= sit_i->mounted_time) > > return sit_i->elapsed_time + now - sit_i->mounted_time; > > diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c > > index 4e8aae03f26c..7bfbead98c04 100644 > > --- a/fs/f2fs/sysfs.c > > +++ b/fs/f2fs/sysfs.c > > @@ -187,6 +187,12 @@ static ssize_t encoding_show(struct f2fs_attr *a, > > return sprintf(buf, "(none)"); > > } > > > > +static ssize_t mounted_time_show(struct f2fs_attr *a, > > + struct f2fs_sb_info *sbi, char *buf) > > +{ > > + return sprintf(buf, "%llu", SIT_I(sbi)->mounted_time); > > +} > > + > > #ifdef CONFIG_F2FS_STAT_FS > > static ssize_t moved_blocks_foreground_show(struct f2fs_attr *a, > > struct f2fs_sb_info *sbi, char *buf) > > @@ -546,6 +552,7 @@ F2FS_GENERAL_RO_ATTR(features); > > F2FS_GENERAL_RO_ATTR(current_reserved_blocks); > > F2FS_GENERAL_RO_ATTR(unusable); > > F2FS_GENERAL_RO_ATTR(encoding); > > +F2FS_GENERAL_RO_ATTR(mounted_time); > > #ifdef CONFIG_F2FS_STAT_FS > > F2FS_STAT_ATTR(STAT_INFO, f2fs_stat_info, cp_foreground_calls, cp_count); > > F2FS_STAT_ATTR(STAT_INFO, f2fs_stat_info, cp_background_calls, bg_cp_count); > > @@ -623,6 +630,7 @@ static struct attribute *f2fs_attrs[] = { > > ATTR_LIST(reserved_blocks), > > ATTR_LIST(current_reserved_blocks), > > ATTR_LIST(encoding), > > + ATTR_LIST(mounted_time), > > #ifdef CONFIG_F2FS_STAT_FS > > ATTR_LIST(cp_foreground_calls), > > ATTR_LIST(cp_background_calls), > >