Re: [PATCH] KVM: nVMX: Consult only the "basic" exit reason when routing nested exit

Paolo Bonzini
2020-02-28T09:57:37Z

On 27/02/20 21:51, Sean Christopherson wrote:
> So part of me thinks the best way to resolve the printing would be to
> modify VMX_EXIT_REASONS to do "| VMX_EXIT_REASONS_FAILED_VMENTRY" where
> appropriate, i.e. on INVALID_STATE, MSR_LOAD_FAIL and MCE_DURING_VMENTRY.
> The downside of that approach is it breaks again when new modifiers come
> along, e.g. SGX's ENCLAVE_EXIT. But again, the modifier is likely useful
> information.
>
> I think the most foolproof and informative way to handle this would be to
> add a macro and/or helper function, e.g. kvm_print_vmx_exit_reason(), to
> wrap __print_symbolic(__entry->exit_code, VMX_EXIT_REASONS) so that it
> prints both the name of the basic exit reason as well as the names for
> any modifiers.
>
> TL;DR: I still like this patch as is, especially since it'll be easy to
> backport. I'll send a separate patch for the tracepoint issue.

Agreed, thanks. I queued this one.

Paolo