From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46C7AC3F2D2 for ; Fri, 28 Feb 2020 11:18:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1466720732 for ; Fri, 28 Feb 2020 11:18:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582888699; bh=fSY96SDopWfyGJlBh/YWZ0XEkxZAt2S5uQ5qaCPocYQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=k/DYdkwI6GtRl0AME+bJ+RBNOrElyFpp/4B2aaRI7SsPT4Zm2ygYWjNgMkTfvxf79 tAchKCQZ10nY3n5Nm9YuXR/SOWXqVYkyFz96OOliyuGrI7gJMtZJ8Xx8qZ7RdGVphb IFYQUCXPo8mQROzZs12qRaqCQ882uAf6WEFh5gC8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725900AbgB1LSS (ORCPT ); Fri, 28 Feb 2020 06:18:18 -0500 Received: from mail.kernel.org ([198.145.29.99]:54670 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725468AbgB1LSR (ORCPT ); Fri, 28 Feb 2020 06:18:17 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DFE9920658; Fri, 28 Feb 2020 11:18:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582888697; bh=fSY96SDopWfyGJlBh/YWZ0XEkxZAt2S5uQ5qaCPocYQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=b2i6didYKoZTm0I9zwFmf0/HY1ZgAdrT+IAWL20dEcr3VqxhALHdTGN792AVKRI8N qyKPzMNH0p48RC3LaFGnGgymWSnZ+rHKVu0K9vWjN9bSLd6i7KAkVguufW6ff/sJtR jf6Ijo3ZFaqLwHxXVW8YmUJyyRO6XOlADv/aD1kg= Date: Fri, 28 Feb 2020 12:18:15 +0100 From: Greg Kroah-Hartman To: Michael Walle Cc: Jiri Slaby , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] serial: earlycon: prefer EARLYCON_DECLARE() variant Message-ID: <20200228111815.GA2915187@kroah.com> References: <20200220174607.24285-1-michael@walle.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 28, 2020 at 11:26:36AM +0100, Michael Walle wrote: > Hi Greg, > > > Am 2020-02-20 18:46, schrieb Michael Walle: > > If a driver exposes early consoles with EARLYCON_DECLARE() and > > OF_EARLYCON_DECLARE(), pefer the non-OF variant if the user specifies it > > by > > earlycon=, > > > > The rationale behind this is that some drivers register multiple setup > > functions under the same driver name. Eg. > > > > OF_EARLYCON_DECLARE(lpuart, "fsl,vf610-lpuart", > > lpuart_early_console_setup); > > OF_EARLYCON_DECLARE(lpuart32, "fsl,ls1021a-lpuart", > > lpuart32_early_console_setup); > > OF_EARLYCON_DECLARE(lpuart32, "fsl,imx7ulp-lpuart", > > lpuart32_imx_early_console_setup); > > EARLYCON_DECLARE(lpuart, lpuart_early_console_setup); > > EARLYCON_DECLARE(lpuart32, lpuart32_early_console_setup); > > > > It depends on the order of the entries which console_setup() actually > > gets called. To make things worse, I guess it also depends on the > > compiler how these are ordered. Thus always prefer the > > EARLYCON_DECLARE() > > ones. > > Do you have an opinon on this proposal? It's only been a week, please give me a chance to catch up on serial patches... thanks, greg k-h