From: Luis Chamberlain <mcgrof@kernel.org>
To: Junyong Sun <sunjy516@gmail.com>
Cc: gregkh@linuxfoundation.org, rafael@kernel.org,
sunjunyong@xiaomi.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firmware: fix a double abort case with fw_load_sysfs_fallback
Date: Fri, 28 Feb 2020 13:07:35 +0000 [thread overview]
Message-ID: <20200228130735.GA11244@42.do-not-panic.com> (raw)
In-Reply-To: <1582876593-27926-1-git-send-email-sunjunyong@xiaomi.com>
On Fri, Feb 28, 2020 at 03:56:33PM +0800, Junyong Sun wrote:
> fw_sysfs_wait_timeout may return err with -ENOENT
> at fw_load_sysfs_fallback and firmware is already
> in abort status, no need to abort again, so skip it.
What exactly is caused by this issue though? Are you seeing
a kernel panic, some extra messages in the kernel log? This
informationw ould be useful for the kernel commit log.
> Signed-off-by: Junyong Sun <sunjunyong@xiaomi.com>
> ---
> drivers/base/firmware_loader/fallback.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/base/firmware_loader/fallback.c b/drivers/base/firmware_loader/fallback.c
> index 8704e1b..1e9c96e 100644
> --- a/drivers/base/firmware_loader/fallback.c
> +++ b/drivers/base/firmware_loader/fallback.c
> @@ -525,7 +525,7 @@ static int fw_load_sysfs_fallback(struct fw_sysfs *fw_sysfs,
> }
>
> retval = fw_sysfs_wait_timeout(fw_priv, timeout);
> - if (retval < 0) {
> + if (retval < 0 && retval != -ENOENT) {
> mutex_lock(&fw_lock);
> fw_load_abort(fw_sysfs);
> mutex_unlock(&fw_lock);
> --
> 2.7.4
>
next prev parent reply other threads:[~2020-02-28 13:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 7:56 [PATCH] firmware: fix a double abort case with fw_load_sysfs_fallback Junyong Sun
2020-02-28 13:07 ` Luis Chamberlain [this message]
2020-03-02 9:23 ` sunjunyong
2020-03-02 18:40 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200228130735.GA11244@42.do-not-panic.com \
--to=mcgrof@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=sunjunyong@xiaomi.com \
--cc=sunjy516@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox