From: Masami Hiramatsu <mhiramat@kernel.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: linux-doc@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
Steven Rostedt <rostedt@goodmis.org>,
Randy Dunlap <rdunlap@infradead.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/2] Documentation: bootconfig: Update boot configuration documentation
Date: Fri, 28 Feb 2020 14:35:28 +0900 [thread overview]
Message-ID: <20200228143528.209db45e5f0f78474ef83387@kernel.org> (raw)
In-Reply-To: <8514c830-319b-33e9-025a-79d399674fb3@web.de>
On Thu, 27 Feb 2020 20:12:17 +0100
Markus Elfring <Markus.Elfring@web.de> wrote:
> > +This allows administrators to pass a structured-Key configuration file
>
> Does capitalisation matter here for the word “Key”?
Oops, thanks! that's a typo of key.
> > +If you think that kernel/init options becomes too long to write in boot-loader
> > +configuration file or want to comment on each options, you can use this
>
> Can the following wording variant be a bit nicer?
>
> +… or you want to comment on each option, …
OK, since the previous sentence is too long, it is more readable to put the
subject there.
> > +Also, some subsystem may depend on the boot configuration, and it has own
> > +root key.
>
> Would you like to explain the influence of a key hierarchy any further?
Please read the example (boot time tracer) carefully :)
> > +The boot configuration syntax allows user to merge partially same word keys
> > by brace. For example::
>
> “by braces.
> For example::”?
I think current one is shorter and compact.
> > +The file /proc/bootconfig is a user-space interface to the configuration
>
> “… is an user-…”?
Hm, it seems "a user" is correct wording.
https://www.quora.com/Which-is-the-correct-usage-a-user-or-an-user
> > +Currently the maximum configuration size is 32 KiB and the total number
> > +of key-words and values must be under 1024 nodes.
>
> * How were these constraints chosen?
>
> * Can such system limits become more configurable?
No.
> > +(Note: Each key consists of words separated by dot, and value also consists
> > +of values separated by comma. Here, each word and each value is generally
> > +called a "node".)
>
> I would prefer the interpretation that nodes contain corresponding attributes.
No. Node is a node. It is merely generic.
>
> How do you think about to add a link to a formal file format description?
Oh, nice idea. Please contribute it :)
Thank you,
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2020-02-28 5:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 7:25 [PATCH 0/2] Documentation: bootconfig: Documentaiton updates Masami Hiramatsu
2020-02-27 7:25 ` [PATCH 1/2] Documentation: bootconfig: Update boot configuration documentation Masami Hiramatsu
2020-02-27 19:12 ` Markus Elfring
2020-02-28 4:36 ` Randy Dunlap
2020-02-28 5:35 ` Masami Hiramatsu [this message]
2020-02-28 8:30 ` [1/2] " Markus Elfring
2020-02-28 13:11 ` Masami Hiramatsu
2020-02-28 13:35 ` Markus Elfring
2020-02-28 4:50 ` [PATCH 1/2] " Randy Dunlap
2020-02-28 6:12 ` Masami Hiramatsu
2020-02-27 7:26 ` [PATCH 2/2] Documentation: bootconfig: Add EBNF syntax file Masami Hiramatsu
2020-02-27 19:53 ` Markus Elfring
2020-02-28 3:15 ` Masami Hiramatsu
2020-02-28 8:46 ` Markus Elfring
2020-02-29 9:00 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200228143528.209db45e5f0f78474ef83387@kernel.org \
--to=mhiramat@kernel.org \
--cc=Markus.Elfring@web.de \
--cc=corbet@lwn.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox