From: Jonathan Cameron <jic23@kernel.org>
To: Sergiu Cuciurean <sergiu.cuciurean@analog.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-iio@vger.kernel.org>,
<gregkh@linuxfoundation.org>, <knaack.h@gmx.de>,
<lars@metafoo.de>, <pmeerw@pmeerw.net>, <info@metux.net>,
<lukas@wunner.de>, <tglx@linutronix.de>
Subject: Re: [PATCH] iio: adc: mcp320x: Use new structure for SPI transfer delays
Date: Sun, 1 Mar 2020 15:50:48 +0000 [thread overview]
Message-ID: <20200301155048.76223dfc@archlinux> (raw)
In-Reply-To: <20200227122940.18243-1-sergiu.cuciurean@analog.com>
On Thu, 27 Feb 2020 14:29:40 +0200
Sergiu Cuciurean <sergiu.cuciurean@analog.com> wrote:
> In a recent change to the SPI subsystem [1], a new `delay` struct was added
> to replace the `delay_usecs`. This change replaces the current
> `delay_usecs` with `delay` for this driver.
>
> The `spi_transfer_delay_exec()` function [in the SPI framework] makes sure
> that both `delay_usecs` & `delay` are used (in this order to preserve
> backwards compatibility).
>
> [1] commit bebcfd272df6 ("spi: introduce `delay` field for
> `spi_transfer` + spi_transfer_delay_exec()")
>
> Signed-off-by: Sergiu Cuciurean <sergiu.cuciurean@analog.com>
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to poke at it.
Thanks,
Jonathan
> ---
> drivers/iio/adc/mcp320x.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/mcp320x.c b/drivers/iio/adc/mcp320x.c
> index 465c7625a55a..2c0eb5de110c 100644
> --- a/drivers/iio/adc/mcp320x.c
> +++ b/drivers/iio/adc/mcp320x.c
> @@ -421,7 +421,8 @@ static int mcp320x_probe(struct spi_device *spi)
> adc->transfer[1].len++;
>
> /* conversions are started by asserting CS pin for 8 usec */
> - adc->start_conv_transfer.delay_usecs = 8;
> + adc->start_conv_transfer.delay.value = 8;
> + adc->start_conv_transfer.delay.unit = SPI_DELAY_UNIT_USECS;
> spi_message_init_with_transfers(&adc->start_conv_msg,
> &adc->start_conv_transfer, 1);
>
prev parent reply other threads:[~2020-03-01 15:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 12:29 [PATCH] iio: adc: mcp320x: Use new structure for SPI transfer delays Sergiu Cuciurean
2020-03-01 15:50 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200301155048.76223dfc@archlinux \
--to=jic23@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=info@metux.net \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=pmeerw@pmeerw.net \
--cc=sergiu.cuciurean@analog.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox