From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96A4FC3F2CD for ; Mon, 2 Mar 2020 00:39:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6910324699 for ; Mon, 2 Mar 2020 00:39:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726758AbgCBAj2 (ORCPT ); Sun, 1 Mar 2020 19:39:28 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:43460 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726592AbgCBAj1 (ORCPT ); Sun, 1 Mar 2020 19:39:27 -0500 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1j8Z7G-003jUU-Ag; Mon, 02 Mar 2020 00:39:26 +0000 Date: Mon, 2 Mar 2020 00:39:26 +0000 From: Al Viro To: Linus Torvalds Cc: linux-fsdevel , Linux Kernel Mailing List Subject: Re: [RFC][PATCHSET] sanitized pathwalk machinery (v3) Message-ID: <20200302003926.GM23230@ZenIV.linux.org.uk> References: <20200223011154.GY23230@ZenIV.linux.org.uk> <20200301215125.GA873525@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 01, 2020 at 04:34:06PM -0600, Linus Torvalds wrote: > On Sun, Mar 1, 2020 at 3:51 PM Al Viro wrote: > > > > Extended since the last repost. The branch is in #work.dotdot; > > #work.do_last is its beginning (about 2/3 of the total), slightly > > reworked since the last time. > > I'm traveling, so only a quick read-through. > > One request: can you add the total diffstat to the cover letter (along > with what you used as a base)? Sure, no problem (and the base is still -rc1) > I did apply it to a branch just to look > at it more closely, so I can see the final diffstat that way: > > Documentation/filesystems/path-lookup.rst | 7 +- > fs/autofs/dev-ioctl.c | 6 +- > fs/internal.h | 1 - > fs/namei.c | 1333 +++++++++------------ > fs/namespace.c | 96 +- > fs/open.c | 4 +- > include/linux/namei.h | 4 +- > 7 files changed, 642 insertions(+), 809 deletions(-) > > but it would have been nice to see in your explanation too. > > Anyway, from a quick read-through, I don't see anything that raises my > hackles - you've fixed the goto label naming, and I didn't notice > anything else odd. > > Maybe that was because I wasn't careful enough. But the final line > count certainly speaks for the series.. Heh... Part of my metrics is actually "how large a sheet of paper does one need to fit the call graph on" ;-) I hope it gets serious beating, though - it touches pretty much every codepath in pathname resolution. Is there any way to sic the bots on a branch, short of "push it into -next and wait for screams"?