Re: [patch 5/8] x86/entry/common: Provide trace/kprobe safe exit to user space functions

Peter Zijlstra
2020-02-26T08:15:21Z

On Tue, Feb 25, 2020 at 09:45:11PM -0800, Andy Lutomirski wrote:
> On 2/25/20 2:08 PM, Thomas Gleixner wrote:
> > Split prepare_enter_to_user_mode() and mark it notrace/noprobe so the irq
> > flags tracing on return can be put into it.
>
> Is our tooling clever enough for thsi to do anything? You have a static
> inline that is only called in one place, and the caller is notrace and
> NOKPROBE. Does this actually allow tracing in the static inline callee?

tracing, no, but the NOKPROBE on inline functions is buggered afaiu.