From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0381BC3F2D1 for ; Mon, 2 Mar 2020 15:18:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CE29D2146E for ; Mon, 2 Mar 2020 15:18:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="oOewtFw6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727387AbgCBPSv (ORCPT ); Mon, 2 Mar 2020 10:18:51 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:36124 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726390AbgCBPSv (ORCPT ); Mon, 2 Mar 2020 10:18:51 -0500 Received: by mail-wm1-f67.google.com with SMTP id g83so8827567wme.1 for ; Mon, 02 Mar 2020 07:18:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=FfGCzyuM1FF4tXwyg52CuI8TXntOiqploqh0HUEy4NI=; b=oOewtFw6V0G8S5MMSYcosVIQLSvrp3qra6NujycuyjHpNha1tBZQVpBUHqld1x+246 NydllS1/71Y0ECUD9b2V9TY0j6r+WK+qsc66ywF2HZqorS6zRzM7RZnA8rgojs1v5h9p /9nEDscV+WDvV01CBokIGxLmi0mjpY14TCr8XSC8UTCqGX9j2k4VOVPFuJ8GlNhK3FBd bR6d1WPlPFMb9VOdvYIexSHW3CSs/MxLeYo0KgT+YINYC4jSp9k76yKJBO/PRXVlWK3K c+0z80jbJ3cww/W5tIAw48YscF9LqznT9oBbCFB+fPuWCmidPbeVPdN/j08TQ4urmaRY cbbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=FfGCzyuM1FF4tXwyg52CuI8TXntOiqploqh0HUEy4NI=; b=g9hIJt1tlfPRF0CiFo6wwmIdHIsW36Tju2OVzFEBbptUpxsAsOVzWXZFWAeJt8l/tu 28Csh7+gvKHehjjYYQkMc9YdWcsz8777UmJ9n8GtechpsCAul6Yiu2RM/zMAhhsHOxvD ge/iD2eBUeHMYmR4D4zIPiMUtbUOo1T/WMJeC0ri6uWPz5ThsQbfBx+jhH72qv6gTq64 SXgu+pbJvayKwFrFcTvlMm7gydMGE8X64GdWelPsCTZ69dMATat15aojuHEQRygTCqpI xVoi7dc8fJzQXDuwDfWAYIInE4Q0PPxJJLF5L+ahDNgyLQAkztCOO25NblCR5SNxbF0I y4HA== X-Gm-Message-State: ANhLgQ3m0CFlqt4N3Kce3BGDs31Uat3Tc1eIwZY9zDs7uC2PBXuk2MHs K0UhwMsDyHYa7b8aXIW6z1ZiGw== X-Google-Smtp-Source: ADFU+vubFBZ38Hl4t+bQp7qMPsZlMtvLHJ5es54H4Ae86JjLqb6AYOoYNbKi5zGROrIxX6nKRM8xRA== X-Received: by 2002:a1c:791a:: with SMTP id l26mr3876wme.58.1583162329063; Mon, 02 Mar 2020 07:18:49 -0800 (PST) Received: from dell ([2.31.163.122]) by smtp.gmail.com with ESMTPSA id o16sm13600468wrj.5.2020.03.02.07.18.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2020 07:18:48 -0800 (PST) Date: Mon, 2 Mar 2020 15:19:24 +0000 From: Lee Jones To: Mika Westerberg Cc: Andy Shevchenko , Darren Hart , Greg Kroah-Hartman , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , x86@kernel.org, Zha Qipeng , "David E . Box" , Guenter Roeck , Heikki Krogerus , Wim Van Sebroeck , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 00/19] platform/x86: Rework intel_scu_ipc and intel_pmc_ipc drivers Message-ID: <20200302151924.GC3494@dell> References: <20200302133327.55929-1-mika.westerberg@linux.intel.com> <20200302142621.GB3494@dell> <20200302143803.GI2667@lahna.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200302143803.GI2667@lahna.fi.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 02 Mar 2020, Mika Westerberg wrote: > On Mon, Mar 02, 2020 at 02:26:21PM +0000, Lee Jones wrote: > > On Mon, 02 Mar 2020, Mika Westerberg wrote: > > > > > Hi all, > > > > > > Currently both intel_scu_ipc.c and intel_pmc_ipc.c implement the same SCU > > > IPC communications with minor differences. This duplication does not make > > > much sense so this series reworks the two drivers so that there is only a > > > single implementation of the SCU IPC. In addition to that the API will be > > > updated to take SCU instance pointer as an argument, and most of the > > > callers will be converted to this new API. The old API is left there but > > > the plan is to get rid the callers and then the old API as well (this is > > > something we are working with Andy Shevchenko). > > > > > > The intel_pmc_ipc.c is then moved under MFD which suits better for this > > > kind of a driver that pretty much sets up the SCU IPC and then creates a > > > bunch of platform devices for the things sitting behind the PMC. The driver > > > is renamed to intel_pmc_bxt.c which should follow the existing conventions > > > under drivers/mfd (and it is only meant for Intel Broxton derivatives). > > > > > > This is on top of platform-driver-x86.git/for-next branch because there is > > > already some cleanup work queued that re-organizes Kconfig and Makefile > > > entries. > > > > > > I have tested this on Intel Joule (Broxton-M) board. > > > > > > Changes from v6: > > > > > > * Added Reviewed-by tag from Andy > > > * Expanded PMC, IPC and IA acronyms > > > * Drop TCO_DEVICE_NAME, PUNIT_DEVICE_NAME and TELEMETRY_DEVICE_NAME > > > * Move struct intel_pmc_dev into include/linux/mfd/intel_pmc_bxt.h > > > * Add PMC_DEVICE_MAX to the enum and use it > > > * Add kernel-docs for simplecmd_store() and northpeak_store() > > > * Use if (ret) return ret; over the ternary operator > > > * Drop "This is index X" from comments > > > * Use acpi_has_watchdog() to determine whether iTCO_wdt is added or not. > > > * Rename intel_scu_ipc_pdata -> intel_scu_ipc_data to make it less > > > confusing wrt. platform data for platform drivers. > > > > Any reason why you've dropped all my tags? > > You mean these? > > For my own reference: > Acked-for-MFD-by: Lee Jones > > I wasn't really sure what to do with them. They are not in the normal > tag format I've seen so I thought you use them yourself somehow to > manage your mailboxes. I can add them back if needed. Yes, please add them, so I can track them. It normally means that I plan to take the set through MFD and subsequently send an immutable pull-request out to the other Maintainers once all the other Acks have been provided. MFD handles these kinds of cross-subsystem patch-sets often. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog