From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Keith Busch <kbusch@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Christoph Hellwig <hch@lst.de>, Sasha Levin <sashal@kernel.org>,
linux-nvme@lists.infradead.org
Subject: [PATCH AUTOSEL 4.19 27/32] nvme: Fix uninitialized-variable warning
Date: Mon, 2 Mar 2020 21:48:46 -0500 [thread overview]
Message-ID: <20200303024851.10054-27-sashal@kernel.org> (raw)
In-Reply-To: <20200303024851.10054-1-sashal@kernel.org>
From: Keith Busch <kbusch@kernel.org>
[ Upstream commit 15755854d53b4bbb0bb37a0fce66f0156cfc8a17 ]
gcc may detect a false positive on nvme using an unintialized variable
if setting features fails. Since this is not a fast path, explicitly
initialize this variable to suppress the warning.
Reported-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Keith Busch <kbusch@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/nvme/host/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index f41fd15b7b7c2..a8132e8d72bb4 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -1058,8 +1058,8 @@ static struct nvme_id_ns *nvme_identify_ns(struct nvme_ctrl *ctrl,
static int nvme_set_features(struct nvme_ctrl *dev, unsigned fid, unsigned dword11,
void *buffer, size_t buflen, u32 *result)
{
+ union nvme_result res = { 0 };
struct nvme_command c;
- union nvme_result res;
int ret;
memset(&c, 0, sizeof(c));
--
2.20.1
next prev parent reply other threads:[~2020-03-03 2:49 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 2:48 [PATCH AUTOSEL 4.19 01/32] ALSA: hda: do not override bus codec_mask in link_get() Sasha Levin
2020-03-03 2:48 ` [PATCH AUTOSEL 4.19 02/32] usb: charger: assign specific number for enum value Sasha Levin
2020-03-03 2:48 ` [PATCH AUTOSEL 4.19 03/32] serial: ar933x_uart: set UART_CS_{RX,TX}_READY_ORIDE Sasha Levin
2020-03-03 2:48 ` [PATCH AUTOSEL 4.19 04/32] selftests: fix too long argument Sasha Levin
2020-03-03 2:48 ` [PATCH AUTOSEL 4.19 05/32] usb: gadget: composite: Support more than 500mA MaxPower Sasha Levin
2020-03-03 2:48 ` [PATCH AUTOSEL 4.19 06/32] usb: gadget: ffs: ffs_aio_cancel(): Save/restore IRQ flags Sasha Levin
2020-03-03 2:48 ` [PATCH AUTOSEL 4.19 07/32] usb: gadget: serial: fix Tx stall after buffer overflow Sasha Levin
2020-03-03 2:48 ` [PATCH AUTOSEL 4.19 08/32] drm/msm/mdp5: rate limit pp done timeout warnings Sasha Levin
2020-03-03 2:48 ` [PATCH AUTOSEL 4.19 09/32] drm: msm: Fix return type of dsi_mgr_connector_mode_valid for kCFI Sasha Levin
2020-03-03 2:48 ` [PATCH AUTOSEL 4.19 10/32] scsi: megaraid_sas: silence a warning Sasha Levin
2020-03-03 2:48 ` [PATCH AUTOSEL 4.19 11/32] drm/msm/dsi: save pll state before dsi host is powered off Sasha Levin
2020-03-03 2:48 ` [PATCH AUTOSEL 4.19 12/32] drm/msm/dsi/pll: call vco set rate explicitly Sasha Levin
2020-03-03 2:48 ` [PATCH AUTOSEL 4.19 13/32] selftests: forwarding: use proto icmp for {gretap, ip6gretap}_mac testing Sasha Levin
2020-03-03 2:48 ` [PATCH AUTOSEL 4.19 14/32] net: atlantic: fix use after free kasan warn Sasha Levin
2020-03-03 2:48 ` [PATCH AUTOSEL 4.19 15/32] net: atlantic: fix potential error handling Sasha Levin
2020-03-03 2:48 ` [PATCH AUTOSEL 4.19 16/32] net: phy: restore mdio regs in the iproc mdio driver Sasha Levin
2020-03-03 2:48 ` [PATCH AUTOSEL 4.19 17/32] net: dsa: b53: Ensure the default VID is untagged Sasha Levin
2020-03-03 2:48 ` [PATCH AUTOSEL 4.19 18/32] net: ks8851-ml: Remove 8-bit bus accessors Sasha Levin
2020-03-03 2:48 ` [PATCH AUTOSEL 4.19 19/32] net: ks8851-ml: Fix 16-bit data access Sasha Levin
2020-03-03 2:48 ` [PATCH AUTOSEL 4.19 20/32] net: ks8851-ml: Fix 16-bit IO operation Sasha Levin
2020-03-03 2:48 ` [PATCH AUTOSEL 4.19 21/32] watchdog: da9062: do not ping the hw during stop() Sasha Levin
2020-03-03 2:48 ` [PATCH AUTOSEL 4.19 22/32] s390/cio: cio_ignore_proc_seq_next should increase position index Sasha Levin
2020-03-03 2:48 ` [PATCH AUTOSEL 4.19 23/32] s390: make 'install' not depend on vmlinux Sasha Levin
2020-03-03 2:48 ` [PATCH AUTOSEL 4.19 24/32] net: mscc: fix in frame extraction Sasha Levin
2020-03-03 2:48 ` [PATCH AUTOSEL 4.19 25/32] x86/boot/compressed: Don't declare __force_order in kaslr_64.c Sasha Levin
2020-03-03 2:48 ` [PATCH AUTOSEL 4.19 26/32] s390/qdio: fill SL with absolute addresses Sasha Levin
2020-03-03 2:48 ` Sasha Levin [this message]
2020-03-03 2:48 ` [PATCH AUTOSEL 4.19 28/32] nfc: pn544: Fix occasional HW initialization failure Sasha Levin
2020-03-03 2:48 ` [PATCH AUTOSEL 4.19 29/32] ice: Don't tell the OS that link is going down Sasha Levin
2020-03-03 2:48 ` [PATCH AUTOSEL 4.19 30/32] x86/xen: Distribute switch variables for initialization Sasha Levin
2020-03-03 2:48 ` [PATCH AUTOSEL 4.19 31/32] s390/qeth: vnicc Fix EOPNOTSUPP precedence Sasha Levin
2020-03-03 2:48 ` [PATCH AUTOSEL 4.19 32/32] net: thunderx: workaround BGX TX Underflow issue Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200303024851.10054-27-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=arnd@arndb.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox