From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D3D7C3F2CD for ; Tue, 3 Mar 2020 02:49:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 688CD24699 for ; Tue, 3 Mar 2020 02:49:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583203769; bh=RMTGr3uER+/FS+YWZ/Knhm57es+YuOsOFMRZAznwVdI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=kYWp/LGYQhS59eLfmmipYDmXywI/gB3uT049Cby53CdwW/OU3eDdUYT0Swg8Gsk+T wcIk2KMlURkDF1GfxTYTfNS4gKra6yvYHlBCfJMr1mmAsQ0SnRelF5KBZla2XgEaU3 JvzOUcWe+QpUQY+RUvmKnv+t69Yyw5uSlleSxkwE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728878AbgCCCt2 (ORCPT ); Mon, 2 Mar 2020 21:49:28 -0500 Received: from mail.kernel.org ([198.145.29.99]:45666 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728865AbgCCCt0 (ORCPT ); Mon, 2 Mar 2020 21:49:26 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7925D246D5; Tue, 3 Mar 2020 02:49:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583203766; bh=RMTGr3uER+/FS+YWZ/Knhm57es+YuOsOFMRZAznwVdI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TLOKnKa0JXbXF/QIPVjzvPa6hHybm3Br7nsJlchOZPmMmpGpkRNJSKpopxPE2M0RL DkqhEBUdvSShA3G+wohEtt8skofzKh7hu2Jt8R/86LJFH1a+CvRN88XiUAPvMcNvIf aLsbatDAp9jIM37GDrfhmjtLQk3a7vaBFzZf/fpk= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Keith Busch , Arnd Bergmann , Christoph Hellwig , Sasha Levin , linux-nvme@lists.infradead.org Subject: [PATCH AUTOSEL 4.19 27/32] nvme: Fix uninitialized-variable warning Date: Mon, 2 Mar 2020 21:48:46 -0500 Message-Id: <20200303024851.10054-27-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200303024851.10054-1-sashal@kernel.org> References: <20200303024851.10054-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Keith Busch [ Upstream commit 15755854d53b4bbb0bb37a0fce66f0156cfc8a17 ] gcc may detect a false positive on nvme using an unintialized variable if setting features fails. Since this is not a fast path, explicitly initialize this variable to suppress the warning. Reported-by: Arnd Bergmann Reviewed-by: Christoph Hellwig Signed-off-by: Keith Busch Signed-off-by: Sasha Levin --- drivers/nvme/host/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index f41fd15b7b7c2..a8132e8d72bb4 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -1058,8 +1058,8 @@ static struct nvme_id_ns *nvme_identify_ns(struct nvme_ctrl *ctrl, static int nvme_set_features(struct nvme_ctrl *dev, unsigned fid, unsigned dword11, void *buffer, size_t buflen, u32 *result) { + union nvme_result res = { 0 }; struct nvme_command c; - union nvme_result res; int ret; memset(&c, 0, sizeof(c)); -- 2.20.1