From: Andreas Klinger <ak@it-klinger.de>
To: YueHaibing <yuehaibing@huawei.com>
Cc: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de,
pmeerw@pmeerw.net, Jonathan.Cameron@huawei.com,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] iio: ping: set pa_laser_ping_cfg in of_ping_match
Date: Wed, 4 Mar 2020 12:55:46 +0100 [thread overview]
Message-ID: <20200304115546.GA8509@arbad> (raw)
In-Reply-To: <20200304113423.26920-1-yuehaibing@huawei.com>
Acked-by: Andreas Klinger <ak@it-klinger.de>
YueHaibing <yuehaibing@huawei.com> schrieb am Mi, 04. Mär 19:34:
> pa_laser_ping_cfg should be set in of_ping_match
> instead of pa_ping_cfg.
>
> Fixes: 7bb501f49ddb ("iio: ping: add parallax ping sensors")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/iio/proximity/ping.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/proximity/ping.c b/drivers/iio/proximity/ping.c
> index 34aff10..12b893c 100644
> --- a/drivers/iio/proximity/ping.c
> +++ b/drivers/iio/proximity/ping.c
> @@ -269,7 +269,7 @@ static const struct iio_chan_spec ping_chan_spec[] = {
>
> static const struct of_device_id of_ping_match[] = {
> { .compatible = "parallax,ping", .data = &pa_ping_cfg},
> - { .compatible = "parallax,laserping", .data = &pa_ping_cfg},
> + { .compatible = "parallax,laserping", .data = &pa_laser_ping_cfg},
> {},
> };
>
> --
> 2.7.4
>
>
next prev parent reply other threads:[~2020-03-04 11:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 11:34 [PATCH -next] iio: ping: set pa_laser_ping_cfg in of_ping_match YueHaibing
2020-03-04 11:55 ` Andreas Klinger [this message]
2020-03-07 15:30 ` Jonathan Cameron
2020-03-10 13:42 ` Yuehaibing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200304115546.GA8509@arbad \
--to=ak@it-klinger.de \
--cc=Jonathan.Cameron@huawei.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox