From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E99F2C3F2D1 for ; Wed, 4 Mar 2020 17:51:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BE5712146E for ; Wed, 4 Mar 2020 17:51:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="KydW31s5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388374AbgCDRvY (ORCPT ); Wed, 4 Mar 2020 12:51:24 -0500 Received: from mail-pg1-f195.google.com ([209.85.215.195]:36624 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729823AbgCDRt5 (ORCPT ); Wed, 4 Mar 2020 12:49:57 -0500 Received: by mail-pg1-f195.google.com with SMTP id d9so1336722pgu.3 for ; Wed, 04 Mar 2020 09:49:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=6Pcd87jXBoko1RLArOK3JOBlDi7LhTUzZixbyRsnysk=; b=KydW31s5IW/9GAa1O2cOf0tr47W3xiu+sI0QS5k4+QTrWO48/QOCDWuN6szRJdWC8t m/ZU4WaUCpLcsf9bclQU0uYpXvxA/CFmAjaIBn9jvqddhcgnTC8rY7ASNGsULHLxRTyz DpGPCTwJLKmg4lkn/XHl8yyhMdUGpPVZxGJTbvxc/hHkx1J5PSmQftvbfoPmI+ElqXgA RLHiSnZdLeCzCa/nSmn7ycYQJ4UrLEiLLec1aKYuIs4xhXwFPUaQVU5eZvXGVVyoPbH6 99wBpcfSf+LzhQq5UeMHjVCCgeycHumKOAST2EsqrhfXlsOzIumoWMlV51O5jA7QPA8q seGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=6Pcd87jXBoko1RLArOK3JOBlDi7LhTUzZixbyRsnysk=; b=LxtUhRamLk+pR9sZUrQji0NVTK9RlxbO2e0mMZ6QtCdFuDtubsnLcGzdPENAAGGzQP QrD6nZ6Qk0+SVjDSDyDJKxHqes9QZHusq3YsvAgd7rWtwABKCGcmiUraRm0JdPEWdqUV 4gG1XeItAj0Z1M2QfGbDGs1QlXDYasOg6nzOa3H/jE4Ix9NceLTzOo5zc4HKGAJF0nTx 4Dx2+uPTRJ5CfbPs5YR2XhpktkV6O9FEqqZLCLibPPT4wFlvwwQVPRSEikRBGS84+xSw mlX/Y10pNyeWAiW6E6GfjIN/XNML0/p59h2oIQ7ZU/38Mwq+SllM6/V+mfec6jD7TEdv CB+g== X-Gm-Message-State: ANhLgQ31L/99U3/f5U7joFKyoo8WZkGTQdtTf4TlrXH8hl8l0YII51Qx ByGopLFzaHbBDZi+1VczCHIsCw== X-Google-Smtp-Source: ADFU+vvRmOFNnEgqA4kQ83WWcrv9V7CjpSLIyfapy8Mc6wnRSXjV1nvF8cP+fFDnku2nnHZ+vIFuvg== X-Received: by 2002:a63:4f0c:: with SMTP id d12mr3689461pgb.322.1583344195976; Wed, 04 Mar 2020 09:49:55 -0800 (PST) Received: from xps15 (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id k1sm7834537pgg.56.2020.03.04.09.49.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2020 09:49:55 -0800 (PST) Date: Wed, 4 Mar 2020 10:49:53 -0700 From: Mathieu Poirier To: Tero Kristo Cc: bjorn.andersson@linaro.org, ohad@wizery.com, linux-remoteproc@vger.kernel.org, afd@ti.com, s-anna@ti.com, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCHv7 09/15] remoteproc/omap: Check for undefined mailbox messages Message-ID: <20200304174953.GH8197@xps15> References: <20200221101936.16833-1-t-kristo@ti.com> <20200221101936.16833-10-t-kristo@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200221101936.16833-10-t-kristo@ti.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 21, 2020 at 12:19:30PM +0200, Tero Kristo wrote: > From: Suman Anna > > Add some checks in the mailbox callback function to limit > any processing in the mailbox callback function to only > certain currently valid messages, and drop all the remaining > messages. A debug message is added to print any such invalid > messages when the appropriate trace control is enabled. > > Co-developed-by: Subramaniam Chanderashekarapuram > Signed-off-by: Subramaniam Chanderashekarapuram > Signed-off-by: Suman Anna > Signed-off-by: Tero Kristo > Reviewed-by: Bjorn Andersson Acked-by: Mathieu Poirier > --- > drivers/remoteproc/omap_remoteproc.c | 6 ++++++ > drivers/remoteproc/omap_remoteproc.h | 7 +++++++ > 2 files changed, 13 insertions(+) > > diff --git a/drivers/remoteproc/omap_remoteproc.c b/drivers/remoteproc/omap_remoteproc.c > index 8c3dc0edae95..5d6f32974aa3 100644 > --- a/drivers/remoteproc/omap_remoteproc.c > +++ b/drivers/remoteproc/omap_remoteproc.c > @@ -130,6 +130,12 @@ static void omap_rproc_mbox_callback(struct mbox_client *client, void *data) > dev_info(dev, "received echo reply from %s\n", name); > break; > default: > + if (msg >= RP_MBOX_READY && msg < RP_MBOX_END_MSG) > + return; > + if (msg > oproc->rproc->max_notifyid) { > + dev_dbg(dev, "dropping unknown message 0x%x", msg); > + return; > + } > /* msg contains the index of the triggered vring */ > if (rproc_vq_interrupt(oproc->rproc, msg) == IRQ_NONE) > dev_dbg(dev, "no message was found in vqid %d\n", msg); > diff --git a/drivers/remoteproc/omap_remoteproc.h b/drivers/remoteproc/omap_remoteproc.h > index f6d2036d383d..72f656c93caa 100644 > --- a/drivers/remoteproc/omap_remoteproc.h > +++ b/drivers/remoteproc/omap_remoteproc.h > @@ -56,6 +56,12 @@ > * > * @RP_MBOX_ABORT_REQUEST: a "please crash" request, used for testing the > * recovery mechanism (to some extent). > + * > + * Introduce new message definitions if any here. > + * > + * @RP_MBOX_END_MSG: Indicates end of known/defined messages from remote core > + * This should be the last definition. > + * > */ > enum omap_rp_mbox_messages { > RP_MBOX_READY = 0xFFFFFF00, > @@ -64,6 +70,7 @@ enum omap_rp_mbox_messages { > RP_MBOX_ECHO_REQUEST = 0xFFFFFF03, > RP_MBOX_ECHO_REPLY = 0xFFFFFF04, > RP_MBOX_ABORT_REQUEST = 0xFFFFFF05, > + RP_MBOX_END_MSG = 0xFFFFFF06, > }; > > #endif /* _OMAP_RPMSG_H */ > -- > 2.17.1 > > -- > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki