From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 697E4C3F2D2 for ; Thu, 5 Mar 2020 17:16:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 341222166E for ; Thu, 5 Mar 2020 17:16:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583428574; bh=rQtpOupHwYghPhu9ux5RH9W43MapO5C+KildPvDQBqQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=XYVLo0l/sezMaBdo0Q8MFIXAvjQFLkeSbsPbvPVCbie1eB5Eus38t1Sn4za10E/YY rQ4aM79U8tqgZZQT3SiPYo6XLUW3ul4fpzCBDpdC1uIfEhThx733QW27N//b34M8lB PNzF2J6gWzuR21E1dGt4Y1knvoHGrsDqfpZHbCPA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728431AbgCERQM (ORCPT ); Thu, 5 Mar 2020 12:16:12 -0500 Received: from mail.kernel.org ([198.145.29.99]:42766 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728289AbgCERPy (ORCPT ); Thu, 5 Mar 2020 12:15:54 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C484E2146E; Thu, 5 Mar 2020 17:15:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583428553; bh=rQtpOupHwYghPhu9ux5RH9W43MapO5C+KildPvDQBqQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=x2z3SBLNM8HobRstAUAriSD5qzukeHmpNNAQvj+CYqf5Wc0/L5W5iO6Kt20M0TBc6 vFhi5U2t7i76HQN7f5wOmePMky2PJHtOOUa6oVgRavrF9YBvDaUOHnegXQeLPL705Y 6Dpslf55a+ajNnyJD4saxH4watRDnfAL5lWhPles= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Igor Druzhinin , Hannes Reinecke , "Martin K . Petersen" , Sasha Levin , linux-scsi@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 10/19] scsi: libfc: free response frame from GPN_ID Date: Thu, 5 Mar 2020 12:15:31 -0500 Message-Id: <20200305171540.30250-10-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200305171540.30250-1-sashal@kernel.org> References: <20200305171540.30250-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Igor Druzhinin [ Upstream commit ff6993bb79b9f99bdac0b5378169052931b65432 ] fc_disc_gpn_id_resp() should be the last function using it so free it here to avoid memory leak. Link: https://lore.kernel.org/r/1579013000-14570-2-git-send-email-igor.druzhinin@citrix.com Reviewed-by: Hannes Reinecke Signed-off-by: Igor Druzhinin Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/libfc/fc_disc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/libfc/fc_disc.c b/drivers/scsi/libfc/fc_disc.c index bb9c1c0166439..28b50ab2fbb01 100644 --- a/drivers/scsi/libfc/fc_disc.c +++ b/drivers/scsi/libfc/fc_disc.c @@ -652,6 +652,8 @@ static void fc_disc_gpn_id_resp(struct fc_seq *sp, struct fc_frame *fp, } out: kref_put(&rdata->kref, fc_rport_destroy); + if (!IS_ERR(fp)) + fc_frame_free(fp); } /** -- 2.20.1