Re: [PATCH 2/3] libperf: avoid redefining _GNU_SOURCE in test

Arnaldo Carvalho de Melo
2020-03-06T11:39:02Z

Em Thu, Mar 05, 2020 at 11:11:09PM -0800, Ian Rogers escreveu:
> _GNU_SOURCE needs to be globally defined to pick up features like
> asprintf. Add a guard against redefinition in this test.

Humm, so you're completely sure that the Makefiles that drive the build
of this file don't set _GNU_SOURCE? I.e. some explanation in the cset
log message about that would help in processing the patch,

- Arnaldo

> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
> tools/lib/perf/tests/test-evlist.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/lib/perf/tests/test-evlist.c b/tools/lib/perf/tests/test-evlist.c
> index 6d8ebe0c2504..5a5ff104b668 100644
> --- a/tools/lib/perf/tests/test-evlist.c
> +++ b/tools/lib/perf/tests/test-evlist.c
> @@ -1,5 +1,7 @@
> // SPDX-License-Identifier: GPL-2.0
> +#ifndef _GNU_SOURCE
> #define _GNU_SOURCE // needed for sched.h to get sched_[gs]etaffinity and CPU_(ZERO,SET)
> +#endif
> #include <sched.h>
> #include <stdio.h>
> #include <stdarg.h>
> --
> 2.25.1.481.gfbce0eb801-goog
>

--

- Arnaldo