[PATCH] w1: ds2430: non functional fixes

[PATCH] w1: ds2430: non functional fixes

[Angelo Dureghello]

Mainly discovered a typo in the eeprom size that may lead to
misunderstandings.

Signed-off-by: Angelo Dureghello <angelo.dureghello@timesys.com>
---
 drivers/w1/slaves/w1_ds2430.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/w1/slaves/w1_ds2430.c b/drivers/w1/slaves/w1_ds2430.c
index 6fb0563fb2ae..67d168ddfb60 100644
--- a/drivers/w1/slaves/w1_ds2430.c
+++ b/drivers/w1/slaves/w1_ds2430.c
@@ -1,7 +1,7 @@
 // SPDX-License-Identifier: GPL-2.0-only
 /*
  * w1_ds2430.c - w1 family 14 (DS2430) driver
- **
+ *
  * Copyright (c) 2019 Angelo Dureghello <angelo.dureghello@timesys.com>
  *
  * Cloned and modified from ds2431
@@ -290,6 +290,6 @@ static struct w1_family w1_family_14 = {
 module_w1_family(w1_family_14);
 
 MODULE_AUTHOR("Angelo Dureghello <angelo.dureghello@timesys.com>");
-MODULE_DESCRIPTION("w1 family 14 driver for DS2430, 256kb EEPROM");
+MODULE_DESCRIPTION("w1 family 14 driver for DS2430, 256b EEPROM");
 MODULE_LICENSE("GPL");
 MODULE_ALIAS("w1-family-" __stringify(W1_EEPROM_DS2430));
-- 
2.25.0

Re: [PATCH] w1: ds2430: non functional fixes

[Greg KH]

On Thu, Mar 05, 2020 at 07:39:51PM +0100, Angelo Dureghello wrote:
> Mainly discovered a typo in the eeprom size that may lead to
> misunderstandings.
> 
> Signed-off-by: Angelo Dureghello <angelo.dureghello@timesys.com>
> ---
>  drivers/w1/slaves/w1_ds2430.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/w1/slaves/w1_ds2430.c b/drivers/w1/slaves/w1_ds2430.c
> index 6fb0563fb2ae..67d168ddfb60 100644
> --- a/drivers/w1/slaves/w1_ds2430.c
> +++ b/drivers/w1/slaves/w1_ds2430.c
> @@ -1,7 +1,7 @@
>  // SPDX-License-Identifier: GPL-2.0-only
>  /*
>   * w1_ds2430.c - w1 family 14 (DS2430) driver
> - **
> + *
>   * Copyright (c) 2019 Angelo Dureghello <angelo.dureghello@timesys.com>
>   *
>   * Cloned and modified from ds2431
> @@ -290,6 +290,6 @@ static struct w1_family w1_family_14 = {
>  module_w1_family(w1_family_14);
>  
>  MODULE_AUTHOR("Angelo Dureghello <angelo.dureghello@timesys.com>");
> -MODULE_DESCRIPTION("w1 family 14 driver for DS2430, 256kb EEPROM");
> +MODULE_DESCRIPTION("w1 family 14 driver for DS2430, 256b EEPROM");
>  MODULE_LICENSE("GPL");
>  MODULE_ALIAS("w1-family-" __stringify(W1_EEPROM_DS2430));
> -- 
> 2.25.0
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch did many different things all at once, making it difficult
  to review.  All Linux kernel patches need to only do one thing at a
  time.  If you need to do multiple things (such as clean up all coding
  style issues in a file/driver), do it in a sequence of patches, each
  one doing only one thing.  This will make it easier to review the
  patches to ensure that they are correct, and to help alleviate any
  merge issues that larger patches can cause.

- You did not specify a description of why the patch is needed, or
  possibly, any description at all, in the email body.  Please read the
  section entitled "The canonical patch format" in the kernel file,
  Documentation/SubmittingPatches for what is needed in order to
  properly describe the change.

- You did not write a descriptive Subject: for the patch, allowing Greg,
  and everyone else, to know what this patch is all about.  Please read
  the section entitled "The canonical patch format" in the kernel file,
  Documentation/SubmittingPatches for what a proper Subject: line should
  look like.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

Re: [PATCH] w1: ds2430: non functional fixes

[Angelo Dureghello]

Hi all,

sorry, no intention to be rude, i replied previously to greg
(email-bot message) only,
without including all, just a mistake.

Was just about asking what to do to fix the issue reported by the bot.

Regards,
Angelo

On Thu, Mar 5, 2020 at 7:45 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Thu, Mar 05, 2020 at 07:39:51PM +0100, Angelo Dureghello wrote:
> > Mainly discovered a typo in the eeprom size that may lead to
> > misunderstandings.
> >
> > Signed-off-by: Angelo Dureghello <angelo.dureghello@timesys.com>
> > ---
> >  drivers/w1/slaves/w1_ds2430.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/w1/slaves/w1_ds2430.c b/drivers/w1/slaves/w1_ds2430.c
> > index 6fb0563fb2ae..67d168ddfb60 100644
> > --- a/drivers/w1/slaves/w1_ds2430.c
> > +++ b/drivers/w1/slaves/w1_ds2430.c
> > @@ -1,7 +1,7 @@
> >  // SPDX-License-Identifier: GPL-2.0-only
> >  /*
> >   * w1_ds2430.c - w1 family 14 (DS2430) driver
> > - **
> > + *
> >   * Copyright (c) 2019 Angelo Dureghello <angelo.dureghello@timesys.com>
> >   *
> >   * Cloned and modified from ds2431
> > @@ -290,6 +290,6 @@ static struct w1_family w1_family_14 = {
> >  module_w1_family(w1_family_14);
> >
> >  MODULE_AUTHOR("Angelo Dureghello <angelo.dureghello@timesys.com>");
> > -MODULE_DESCRIPTION("w1 family 14 driver for DS2430, 256kb EEPROM");
> > +MODULE_DESCRIPTION("w1 family 14 driver for DS2430, 256b EEPROM");
> >  MODULE_LICENSE("GPL");
> >  MODULE_ALIAS("w1-family-" __stringify(W1_EEPROM_DS2430));
> > --
> > 2.25.0
> >
>
> Hi,
>
> This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
> a patch that has triggered this response.  He used to manually respond
> to these common problems, but in order to save his sanity (he kept
> writing the same thing over and over, yet to different people), I was
> created.  Hopefully you will not take offence and will fix the problem
> in your patch and resubmit it so that it can be accepted into the Linux
> kernel tree.
>
> You are receiving this message because of the following common error(s)
> as indicated below:
>
> - Your patch did many different things all at once, making it difficult
>   to review.  All Linux kernel patches need to only do one thing at a
>   time.  If you need to do multiple things (such as clean up all coding
>   style issues in a file/driver), do it in a sequence of patches, each
>   one doing only one thing.  This will make it easier to review the
>   patches to ensure that they are correct, and to help alleviate any
>   merge issues that larger patches can cause.
>
> - You did not specify a description of why the patch is needed, or
>   possibly, any description at all, in the email body.  Please read the
>   section entitled "The canonical patch format" in the kernel file,
>   Documentation/SubmittingPatches for what is needed in order to
>   properly describe the change.
>
> - You did not write a descriptive Subject: for the patch, allowing Greg,
>   and everyone else, to know what this patch is all about.  Please read
>   the section entitled "The canonical patch format" in the kernel file,
>   Documentation/SubmittingPatches for what a proper Subject: line should
>   look like.
>
> If you wish to discuss this problem further, or you have questions about
> how to resolve this issue, please feel free to respond to this email and
> Greg will reply once he has dug out from the pending patches received
> from other developers.
>
> thanks,
>
> greg k-h's patch email bot



-- 
Angelo Dureghello
Timesys
e. angelo.dureghello@timesys.com

Re: [PATCH] w1: ds2430: non functional fixes

[Greg KH]

On Fri, Mar 06, 2020 at 03:21:23PM +0100, Angelo Dureghello wrote:
> Hi all,
> 
> sorry, no intention to be rude, i replied previously to greg
> (email-bot message) only,
> without including all, just a mistake.
> 
> Was just about asking what to do to fix the issue reported by the bot.

Do what it says, break this up into at different patches (only do one
thing per patch, and fix the subject and changelog text to be contain
the needed information, based on the links to the documentation it
provided you.

thanks,

greg k-h