From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E0D0C10DCE for ; Fri, 6 Mar 2020 18:04:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F355420665 for ; Fri, 6 Mar 2020 18:04:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726650AbgCFSE0 (ORCPT ); Fri, 6 Mar 2020 13:04:26 -0500 Received: from muru.com ([72.249.23.125]:59188 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725922AbgCFSEZ (ORCPT ); Fri, 6 Mar 2020 13:04:25 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id D821E8027; Fri, 6 Mar 2020 18:05:10 +0000 (UTC) Date: Fri, 6 Mar 2020 10:04:22 -0800 From: Tony Lindgren To: Lokesh Vutla Cc: Thierry Reding , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Linux OMAP Mailing List , linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, Sekhar Nori , Vignesh R Subject: Re: [PATCH v2 3/6] pwm: omap-dmtimer: Fix pwm enabling sequence Message-ID: <20200306180422.GI37466@atomide.com> References: <20200228095651.32464-1-lokeshvutla@ti.com> <20200228095651.32464-4-lokeshvutla@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200228095651.32464-4-lokeshvutla@ti.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Lokesh Vutla [200228 09:58]: > To configure DM timer in pwm mode the following needs to be set in > OMAP_TIMER_CTRL_REG using set_pwm callback: > - Set toggle mode on PORTIMERPWM output pin > - Set trigger on overflow and match on PORTIMERPWM output pin. > - Set auto reload > > This is a one time configuration and needs to be set before the start of > the dm timer. But the current driver tries to set the same configuration > for every period/duty cycle update, which is not needed. So move the pwm > setup before enabling timer and do not update it in pwm_omap_dmtimer_config. Still works for me: Tested-by: Tony Lindgren