From: Benson Leung <bleung@google.com>
To: Gwendal Grignou <gwendal@chromium.org>
Cc: bleung@chromium.org, enric.balletbo@collabora.com,
jflat@chromium.org, linux-kernel@vger.kernel.org,
pmalani@chromium.org
Subject: Re: [PATCH] platform: chrome: Fix cros-usbpd-notify notifier
Date: Fri, 6 Mar 2020 10:46:29 -0800 [thread overview]
Message-ID: <20200306184629.GA253583@google.com> (raw)
In-Reply-To: <20200304232108.149553-1-gwendal@chromium.org>
[-- Attachment #1: Type: text/plain, Size: 1410 bytes --]
Hi Gwendal,
On Wed, Mar 04, 2020 at 03:21:08PM -0800, Gwendal Grignou wrote:
> cros-usbpd-notify notifier was returning NOTIFY_BAD when no host event
> was available in the MKBP message.
> But MKBP messages are used to transmit other information, so return
> NOTIFY_DONE instead, to allow other notifier to be called.
>
> Fixes: ec2daf6e33f9f ("platform: chrome: Add cros-usbpd-notify driver")
>
> Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Queued for v5.7.
Thank you,
Benson
> ---
> drivers/platform/chrome/cros_usbpd_notify.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/chrome/cros_usbpd_notify.c b/drivers/platform/chrome/cros_usbpd_notify.c
> index 3851bbd6e9a39..ca2c0181a1dbf 100644
> --- a/drivers/platform/chrome/cros_usbpd_notify.c
> +++ b/drivers/platform/chrome/cros_usbpd_notify.c
> @@ -84,7 +84,7 @@ static int cros_usbpd_notify_plat(struct notifier_block *nb,
> u32 host_event = cros_ec_get_host_event(ec_dev);
>
> if (!host_event)
> - return NOTIFY_BAD;
> + return NOTIFY_DONE;
>
> if (host_event & EC_HOST_EVENT_MASK(EC_HOST_EVENT_PD_MCU)) {
> blocking_notifier_call_chain(&cros_usbpd_notifier_list,
> --
> 2.25.0.265.gbab2e86ba0-goog
>
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2020-03-06 18:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 23:21 [PATCH] platform: chrome: Fix cros-usbpd-notify notifier Gwendal Grignou
2020-03-05 0:03 ` Benson Leung
2020-03-06 18:46 ` Benson Leung [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200306184629.GA253583@google.com \
--to=bleung@google.com \
--cc=bleung@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=gwendal@chromium.org \
--cc=jflat@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmalani@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox