From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0456EC10F26 for ; Sat, 7 Mar 2020 12:09:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D219C206D5 for ; Sat, 7 Mar 2020 12:09:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583582991; bh=wVfsIRTo1dZQhjeuU0x1McX2IlXWTN3PEbN4+tM98j4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=pMczZVkpgJ2NbznFp2KDfJ0GlKztlsU8H3UJt8CEL126L7cnd61AL8ojPSowrwpI8 bpnd9zxCNnZnuHIz1kJUxM/qiem6RlRO8JcmD4mphN7piCjfBQmoQ/M1f8nbKASGtH Pnf5vPXcqwQp3W2spbLmjSFA4gq3ZTP/IfEem1EU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726291AbgCGMJu (ORCPT ); Sat, 7 Mar 2020 07:09:50 -0500 Received: from mail.kernel.org ([198.145.29.99]:52636 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726104AbgCGMJu (ORCPT ); Sat, 7 Mar 2020 07:09:50 -0500 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3ADA1206D5; Sat, 7 Mar 2020 12:09:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583582989; bh=wVfsIRTo1dZQhjeuU0x1McX2IlXWTN3PEbN4+tM98j4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=2sLERTBveKXyRYHPBsO8wyvQyqkOI8fKx97HGemxCj7RJPhpCYW874E8XV1n5G4Ht e/Y1GZCyI+n6uRnFpUKjIcOSZY75rBEyMfMgtKFJGGjsaCTJo1mYishV1/CpvYTWxU gW8zWYsU8DPc1xRH5w06sEI07YzG3brSxoPDJeAM= Date: Sat, 7 Mar 2020 12:09:44 +0000 From: Jonathan Cameron To: Alexandru Tachici Cc: , Subject: Re: [PATCH v2 6/6] iio: accel: adxl372: Update sysfs docs Message-ID: <20200307120944.5e369676@archlinux> In-Reply-To: <20200225120909.12629-7-alexandru.tachici@analog.com> References: <20200225120909.12629-1-alexandru.tachici@analog.com> <20200225120909.12629-7-alexandru.tachici@analog.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 25 Feb 2020 14:09:09 +0200 Alexandru Tachici wrote: > This patch adds entries in the syfs docs of ADXL372. > > Signed-off-by: Stefan Popa > Signed-off-by: Alexandru Tachici > --- > .../ABI/testing/sysfs-bus-iio-accel-adxl372 | 30 +++++++++++++++++++ > 1 file changed, 30 insertions(+) > create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-accel-adxl372 > > diff --git a/Documentation/ABI/testing/sysfs-bus-iio-accel-adxl372 b/Documentation/ABI/testing/sysfs-bus-iio-accel-adxl372 > new file mode 100644 > index 000000000000..709376b54bec > --- /dev/null > +++ b/Documentation/ABI/testing/sysfs-bus-iio-accel-adxl372 > @@ -0,0 +1,30 @@ > +What: /sys/bus/iio/devices/iio:deviceX/buffer_peak_mode_enable > +KernelVersion: > +Contact: linux-iio@vger.kernel.org > +Description: > + This attribute allows to configure the FIFO to store sample > + sets of impact event peak (x, y, z). As a precondition, all > + three channels (x, y, z) need to be enabled. > + Writing 1, peak fifo mode will be enabled, if cleared and > + all three channels are enabled, sample sets of concurrent > + 3-axis data will be stored in the FIFO. As this is referring to the internal fifo (I think!) should we name it hwfifo_peak_mode_enable to separate it from being related to the software "buffer"? > + > +What: /sys/bus/iio/devices/iio:deviceX/activity_detect_event > +KernelVersion: > +Contact: linux-iio@vger.kernel.org > +Description: > + adxl372 works in loop mode. It will loop between activity > + and inactivity detection mode. The thresh_rising sysfs files > + found in events/ need to be configured in order to define when > + the device will mark a sensed acceleration over a period of > + time as activity. Hmm. As you noted in the cover letter this is a bit odd having a mixture of an event and a more fundamental state control. Please state what value this will provide when read. > + > +What: /sys/bus/iio/devices/iio:deviceX/inactivity_detect_event > +KernelVersion: > +Contact: linux-iio@vger.kernel.org > +Description: > + adxl372 works in loop mode. It will loop between activity > + and inactivity detection mode. The thresh_falling sysfs files > + found in events/ need to be configured in order to define when > + the device will mark a sensed acceleration over a period of > + time as inactivity.