From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 780D6C10F29 for ; Sun, 8 Mar 2020 08:10:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4BE61208CD for ; Sun, 8 Mar 2020 08:10:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583655035; bh=5SC+HI9MHr7LdNhxNxpWEXOBZOuUx1D7HzGLFIUcHFI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=0I7CnuhbKlc3D0Ay8nuA7uTSpYMXDrCmmUJgU2t9m86PGnonjHehBXVKINkHmQ89j p0MX+F9tRC8sfVIb/1I9EV+QmByeExG+jGnvpLAO96OjmBN1SQK9r3RIRNGtZsw8or PquFPy76TIDfiTHW8MqwXy6SiqTDFJX+4r8tv/f0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726954AbgCHIKe (ORCPT ); Sun, 8 Mar 2020 04:10:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:38514 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726910AbgCHIKc (ORCPT ); Sun, 8 Mar 2020 04:10:32 -0400 Received: from e123331-lin.home (amontpellier-657-1-18-247.w109-210.abo.wanadoo.fr [109.210.65.247]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 05C9320866; Sun, 8 Mar 2020 08:10:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583655032; bh=5SC+HI9MHr7LdNhxNxpWEXOBZOuUx1D7HzGLFIUcHFI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YhVJS+13p9fNy4wznVN9g3m2Xiuio7BAfMyF+tWnM4YCZCiqP6V5Yw4uuP129z5OZ Ypbe+DytMbNOAH61N+Ypxfhmo6D2NQYkMN5lFSOnmFc8Xj7ec87jLq2sASQ1FLug85 Lr3SgZ0p42L7xa/yu35rP41DNOIIG6FCGsOyE+sg= From: Ard Biesheuvel To: linux-efi@vger.kernel.org, Ingo Molnar , Thomas Gleixner Cc: Ard Biesheuvel , linux-kernel@vger.kernel.org, Arvind Sankar , Christoph Hellwig , David Hildenbrand , Davidlohr Bueso , Guenter Roeck , Heinrich Schuchardt , Jonathan Corbet , Lukas Bulwahn , Masahiro Yamada , Nikolai Merinov , Tom Lendacky , Vladis Dronov Subject: [PATCH 24/28] efi: add a sanity check to efivar_store_raw() Date: Sun, 8 Mar 2020 09:08:55 +0100 Message-Id: <20200308080859.21568-25-ardb@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200308080859.21568-1-ardb@kernel.org> References: <20200308080859.21568-1-ardb@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vladis Dronov Add a sanity check to efivar_store_raw() the same way efivar_{attr,size,data}_read() and efivar_show_raw() have it. Signed-off-by: Vladis Dronov Link: https://lore.kernel.org/r/20200305084041.24053-3-vdronov@redhat.com Signed-off-by: Ard Biesheuvel --- drivers/firmware/efi/efivars.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/firmware/efi/efivars.c b/drivers/firmware/efi/efivars.c index 485c592d7990..78ad1ba8c987 100644 --- a/drivers/firmware/efi/efivars.c +++ b/drivers/firmware/efi/efivars.c @@ -208,6 +208,9 @@ efivar_store_raw(struct efivar_entry *entry, const char *buf, size_t count) u8 *data; int err; + if (!entry || !buf) + return -EINVAL; + if (in_compat_syscall()) { struct compat_efi_variable *compat; -- 2.17.1