From: Mel Gorman <mgorman@suse.de>
To: qiwuchen55@gmail.com
Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com,
linux-kernel@vger.kernel.org, chenqiwu <chenqiwu@xiaomi.com>
Subject: Re: [PATCH] sched/fair: fix build warning about undefined test_idle_cores()
Date: Sun, 8 Mar 2020 18:34:48 +0000 [thread overview]
Message-ID: <20200308183448.GI3772@suse.de> (raw)
In-Reply-To: <1583682792-30844-1-git-send-email-qiwuchen55@gmail.com>
On Sun, Mar 08, 2020 at 11:53:12PM +0800, qiwuchen55@gmail.com wrote:
> From: chenqiwu <chenqiwu@xiaomi.com>
>
> The build with arm64's defconfig:
> CONFIG_SCHED_MC=y
> # CONFIG_SCHED_SMT is not set
>
> Trigger the following warning due to test_idle_cores()'s definition
> missing:
> kernel/sched/fair.c:1524:20: warning: ???test_idle_cores??? declared ???static???
> but never defined [-Wunused-function]
>
> Move the CONFIG_SCHED_SMT ifdeffery around test_idle_cores()'s declaration
> to fix it.
>
> Signed-off-by: chenqiwu <chenqiwu@xiaomi.com>
Thanks. A fix has been merged to tip/sched/core as
commit 76c389ab2b5e300698eab87f9d4b7916f14117ba
Author: Valentin Schneider <valentin.schneider@arm.com>
Date: Tue Mar 3 11:02:57 2020 +0000
sched/fair: Fix kernel build warning in test_idle_cores() for !SMT NUMA
--
Mel Gorman
SUSE Labs
prev parent reply other threads:[~2020-03-08 18:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-08 15:53 [PATCH] sched/fair: fix build warning about undefined test_idle_cores() qiwuchen55
2020-03-08 18:34 ` Mel Gorman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200308183448.GI3772@suse.de \
--to=mgorman@suse.de \
--cc=bsegall@google.com \
--cc=chenqiwu@xiaomi.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=qiwuchen55@gmail.com \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox