From: Pavel Machek <pavel@ucw.cz>
To: Tobias Schramm <t.schramm@manjaro.org>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Dan Murphy <dmurphy@ti.com>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 0/1] Add generic inverted led triggers
Date: Sun, 8 Mar 2020 22:26:49 +0100 [thread overview]
Message-ID: <20200308212649.GA31247@amd> (raw)
In-Reply-To: <20200308142722.1199260-1-t.schramm@manjaro.org>
[-- Attachment #1: Type: text/plain, Size: 1412 bytes --]
Hi!
> This patch adds generic inverted LED triggers. With this patch applied
> any trigger can be used with inverted brightness levels by appending
> "-inverted" to the name of a trigger.
Not a big fan (sorry).
We have already _way_ too many triggers, we don't want to have twice
that much.
> This is can be useful for devices that do not have dedicated LEDs for e.g.
> disk activity indication. With this patch applied the power led can be set
> to default-state = on and trigger = disk-activity-inverted. Then the led
> will be on by default, indicating the power state of the device but it
> will turn off briefly whenever there is disk activity.
Better implementation might be to have a trigger attribute doing the
inverting.
> I think dual-use of LEDs might come in handy for quite a few devices since
> a lot of embedded boards and upcoming ARM based notebooks do only have one
> or two LEDs.
Inverting really does not work with all the triggers; numlock-inverted
will not get too many
users. always-on-inverted... blink-inverted.... I guess it does make
sense for disk activity (but be warned disk can be continuously active
for quite a while).
What triggers do you think make sense inverted?
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2020-03-08 21:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-08 14:27 [RFC PATCH 0/1] Add generic inverted led triggers Tobias Schramm
2020-03-08 14:27 ` [RFC PATCH 1/1] leds: add generic inverted led trigger support Tobias Schramm
2020-03-08 17:35 ` Jacek Anaszewski
2020-03-09 13:46 ` Tobias Schramm
2020-03-08 21:26 ` Pavel Machek [this message]
2020-03-09 14:05 ` [RFC PATCH 0/1] Add generic inverted led triggers Tobias Schramm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200308212649.GA31247@amd \
--to=pavel@ucw.cz \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=t.schramm@manjaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox