From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87BEDC10F27 for ; Sun, 8 Mar 2020 21:26:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 68467206D5 for ; Sun, 8 Mar 2020 21:26:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726446AbgCHV0w (ORCPT ); Sun, 8 Mar 2020 17:26:52 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:45244 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726332AbgCHV0w (ORCPT ); Sun, 8 Mar 2020 17:26:52 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 59F571C0317; Sun, 8 Mar 2020 22:26:50 +0100 (CET) Date: Sun, 8 Mar 2020 22:26:49 +0100 From: Pavel Machek To: Tobias Schramm Cc: Jacek Anaszewski , Dan Murphy , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 0/1] Add generic inverted led triggers Message-ID: <20200308212649.GA31247@amd> References: <20200308142722.1199260-1-t.schramm@manjaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="fUYQa+Pmc3FrFX/N" Content-Disposition: inline In-Reply-To: <20200308142722.1199260-1-t.schramm@manjaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --fUYQa+Pmc3FrFX/N Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > This patch adds generic inverted LED triggers. With this patch applied > any trigger can be used with inverted brightness levels by appending > "-inverted" to the name of a trigger. Not a big fan (sorry). We have already _way_ too many triggers, we don't want to have twice that much. > This is can be useful for devices that do not have dedicated LEDs for e.g. > disk activity indication. With this patch applied the power led can be set > to default-state =3D on and trigger =3D disk-activity-inverted. Then the= led > will be on by default, indicating the power state of the device but it > will turn off briefly whenever there is disk activity. Better implementation might be to have a trigger attribute doing the inverting. > I think dual-use of LEDs might come in handy for quite a few devices since > a lot of embedded boards and upcoming ARM based notebooks do only have one > or two LEDs. Inverting really does not work with all the triggers; numlock-inverted will not get too many users. always-on-inverted... blink-inverted.... I guess it does make sense for disk activity (but be warned disk can be continuously active for quite a while). What triggers do you think make sense inverted? Best regards, Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --fUYQa+Pmc3FrFX/N Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAl5lYxkACgkQMOfwapXb+vLCcQCdFXTGZclHREpMmf1wjB+Wzmt/ 4ecAoLyzF2muOElkuYhK0/xFDh6/XBA2 =abBt -----END PGP SIGNATURE----- --fUYQa+Pmc3FrFX/N--