From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 615B7C10F27 for ; Mon, 9 Mar 2020 07:13:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2627F206D5 for ; Mon, 9 Mar 2020 07:13:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583738033; bh=hWJNtQQWqHRyt/XLzVAneJ9w+0DP6eb16gOqermGfK4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=UPKrzDkZzLv/UVciOQCHPRIYRVuIMAB6aGdVwiLGxragIraXpEDInzYnQFYN8SI5v XvbnRc7oPwZkcso7wDE/9As0JpYhrkaJGre28m9Jvz9y2uS5KHaJhcW03ZPVFjtkV8 9HaXrIVJjp921CEWfhlTEmF5+GB1E5RD8dS4R7yA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726446AbgCIHNw (ORCPT ); Mon, 9 Mar 2020 03:13:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:41062 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725962AbgCIHNv (ORCPT ); Mon, 9 Mar 2020 03:13:51 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 60A6B20665; Mon, 9 Mar 2020 07:13:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583738029; bh=hWJNtQQWqHRyt/XLzVAneJ9w+0DP6eb16gOqermGfK4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=0NGCAh9Ya1os58fUGPLB9nQIhrLPnfOGcT/cS+gtCSt92Ol7VwgxGQORw2V1f8E1O I4IGx8WmdRn2MdGdS9w28Clj2MwcXGBkI3p7gevHcIryid4ydJMNFoJCdmX8F++Y7C lAsqKLNZ5f95t9ThGhLv1r7AAYQ8Yp0mm2D+uNc4= Date: Mon, 9 Mar 2020 08:13:47 +0100 From: Greg KH To: Zhenzhong Duan Cc: linux-kernel@vger.kernel.org, jdike@addtoit.com, richard@nod.at, anton.ivanov@cambridgegreys.com, miguel.ojeda.sandonis@gmail.com, willy@haproxy.com, ksenija.stanojevic@gmail.com, arnd@arndb.de, mpm@selenic.com, herbert@gondor.apana.org.au, jonathan@buzzard.org.uk, benh@kernel.crashing.org, davem@davemloft.net, b.zolnierkie@samsung.com, rjw@rjwysocki.net, pavel@ucw.cz, len.brown@intel.com Subject: Re: [PATCH RFC 0/3] clean up misc device minor numbers Message-ID: <20200309071347.GA4095204@kroah.com> References: <20200309021747.626-1-zhenzhong.duan@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200309021747.626-1-zhenzhong.duan@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 09, 2020 at 10:17:44AM +0800, Zhenzhong Duan wrote: > Some the misc device minor numbers definitions spread in different > local c files, specially some are duplicate number with different > name, some are same name with conflict numbers, some prefer dynamic > minors. > > This patchset try to address all of them. > > To be honest, I didn't try build on arm or sparc arch which some > drivers depend on as I have little experience on cross-compile. > But I still checked the patch carefully to ensure it builds > in theory. Appreciate if anyone willing to test build on those arch. > > Zhenzhong Duan (3): > misc: cleanup minor number definitions in c file into miscdevice.h > misc: move FLASH_MINOR into miscdevice.h and fix conflicts > speakup: misc: Use dynamic minor numbers for speakup devices Many thanks for this work, I think they all look sane except maybe the last one, I'll respond there to that. thanks, greg k-h