From: Tejun Heo <tj@kernel.org>
To: Joe Perches <joe@perches.com>
Cc: Daniel Xu <dxu@dxuuu.xyz>,
cgroups@vger.kernel.org, lizefan@huawei.com, hannes@cmpxchg.org,
shakeelb@google.com, linux-kernel@vger.kernel.org,
gregkh@linuxfoundation.org, kernel-team@fb.com
Subject: Re: [PATCH v2 1/4] kernfs: kvmalloc xattr value instead of kmalloc
Date: Mon, 9 Mar 2020 15:51:20 -0400 [thread overview]
Message-ID: <20200309195104.GA77841@mtj.thefacebook.com> (raw)
In-Reply-To: <6bbfc8b8c9c206d80de43a64bfe4b8083cc2c02f.camel@perches.com>
On Mon, Mar 09, 2020 at 12:41:05PM -0700, Joe Perches wrote:
> If the need is to allocate from a single block of memory,
> perhaps you need a submemory allocator like gen_pool.
> (gennalloc.h)
>
> Dunno. Maybe i just don't quite understand your need.
vmalloc is the right thing to do here. vmalloc space isn't a scarce
resource on any 64bit machines. On 32bits, which basically are tiny
machines at this point, these allocations are both size and quantity
limited by other factors (e.g. each cgroup consumes way more memory).
--
tejun
next prev parent reply other threads:[~2020-03-09 19:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 21:16 [PATCH v2 0/4] Support user xattrs in cgroupfs Daniel Xu
2020-03-05 21:16 ` [PATCH v2 1/4] kernfs: kvmalloc xattr value instead of kmalloc Daniel Xu
2020-03-06 8:49 ` Joe Perches
2020-03-06 9:37 ` Greg KH
2020-03-09 18:21 ` Daniel Xu
2020-03-09 19:41 ` Joe Perches
2020-03-09 19:51 ` Tejun Heo [this message]
2020-03-09 19:58 ` Joe Perches
2020-03-09 20:05 ` Tejun Heo
2020-03-10 19:40 ` Shakeel Butt
2020-03-10 20:40 ` Daniel Xu
2020-03-10 20:41 ` Shakeel Butt
2020-03-05 21:16 ` [PATCH v2 2/4] kernfs: Add removed_size out param for simple_xattr_set Daniel Xu
2020-03-10 18:20 ` Daniel Xu
2020-03-05 21:16 ` [PATCH v2 3/4] kernfs: Add option to enable user xattrs Daniel Xu
2020-03-05 21:16 ` [PATCH v2 4/4] cgroupfs: Support " Daniel Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200309195104.GA77841@mtj.thefacebook.com \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=dxu@dxuuu.xyz \
--cc=gregkh@linuxfoundation.org \
--cc=hannes@cmpxchg.org \
--cc=joe@perches.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=shakeelb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox