From: Peter Xu <peterx@redhat.com>
To: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, Yan Zhao <yan.y.zhao@intel.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
Alex Williamson <alex.williamson@redhat.com>,
Sean Christopherson <sean.j.christopherson@intel.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Kevin Tian <kevin.tian@intel.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Christophe de Dinechin <dinechin@redhat.com>,
Lei Cao <lei.cao@stratus.com>
Subject: Re: [PATCH v5 05/14] KVM: X86: Implement ring-based dirty memory tracking
Date: Mon, 9 Mar 2020 17:35:54 -0400 [thread overview]
Message-ID: <20200309213554.GF4206@xz-x1> (raw)
In-Reply-To: <202003061911.MfG74mgX%lkp@intel.com>
On Fri, Mar 06, 2020 at 07:32:20PM +0800, kbuild test robot wrote:
> Hi Peter,
>
> Thank you for the patch! Yet something to improve:
>
> [auto build test ERROR on tip/auto-latest]
> [also build test ERROR on linus/master v5.6-rc4]
> [cannot apply to kvm/linux-next linux/master vhost/linux-next next-20200305]
> [if your patch is applied to the wrong git tree, please drop us a note to help
> improve the system. BTW, we also suggest to use '--base' option to specify the
> base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
>
> url: https://github.com/0day-ci/linux/commits/Peter-Xu/KVM-Dirty-ring-interface/20200305-053531
> base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 6f2bc932d8ff72b1a0a5c66f3dad04ccba576a8b
> config: s390-alldefconfig (attached as .config)
> compiler: s390-linux-gcc (GCC) 7.5.0
> reproduce:
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # save the attached .config to linux build tree
> GCC_VERSION=7.5.0 make.cross ARCH=s390
>
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> arch/s390/../../virt/kvm/kvm_main.o: In function `kvm_reset_dirty_gfn':
> >> kvm_main.c:(.text+0x6a60): undefined reference to `kvm_arch_mmu_enable_log_dirty_pt_masked'
It turns out that when I wanted to fix the build error previously, I
did the compilation test (using a ppc64 host) without using the
correct config file, so KVM is not enabled at all...
I'll fix it (again) this time by moving kvm_reset_dirty_gfn() into
kvm_dirty_ring.c (and some other macro touch-ups). I'll probably also
move KVM_DIRTY_LOG_PAGE_OFFSET==0 definition to uapi/linux/kvm.h.
Thanks,
--
Peter Xu
next prev parent reply other threads:[~2020-03-09 21:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 17:49 [PATCH v5 00/14] KVM: Dirty ring interface Peter Xu
2020-03-04 17:49 ` [PATCH v5 01/14] KVM: X86: Change parameter for fast_page_fault tracepoint Peter Xu
2020-03-04 17:49 ` [PATCH v5 02/14] KVM: Cache as_id in kvm_memory_slot Peter Xu
2020-03-04 17:49 ` [PATCH v5 03/14] KVM: X86: Don't track dirty for KVM_SET_[TSS_ADDR|IDENTITY_MAP_ADDR] Peter Xu
2020-03-04 17:49 ` [PATCH v5 04/14] KVM: Pass in kvm pointer into mark_page_dirty_in_slot() Peter Xu
2020-03-04 17:49 ` [PATCH v5 05/14] KVM: X86: Implement ring-based dirty memory tracking Peter Xu
2020-03-06 11:32 ` kbuild test robot
2020-03-09 21:35 ` Peter Xu [this message]
2020-03-10 6:31 ` Michael S. Tsirkin
2020-03-10 14:09 ` Peter Xu
2020-03-10 14:11 ` Michael S. Tsirkin
2020-03-10 14:19 ` Peter Xu
2020-03-10 14:46 ` Michael S. Tsirkin
2020-03-04 17:49 ` [PATCH v5 06/14] KVM: Make dirty ring exclusive to dirty bitmap log Peter Xu
2020-03-04 17:49 ` [PATCH v5 07/14] KVM: Don't allocate dirty bitmap if dirty ring is enabled Peter Xu
2020-03-04 17:49 ` [PATCH v5 08/14] KVM: selftests: Always clear dirty bitmap after iteration Peter Xu
2020-03-04 17:49 ` [PATCH v5 09/14] KVM: selftests: Sync uapi/linux/kvm.h to tools/ Peter Xu
2020-03-04 17:49 ` [PATCH v5 10/14] KVM: selftests: Use a single binary for dirty/clear log test Peter Xu
2020-03-04 17:49 ` [PATCH v5 11/14] KVM: selftests: Introduce after_vcpu_run hook for dirty " Peter Xu
2020-03-04 17:49 ` [PATCH v5 12/14] KVM: selftests: Add dirty ring buffer test Peter Xu
2020-03-04 17:49 ` [PATCH v5 13/14] KVM: selftests: Let dirty_log_test async for dirty ring test Peter Xu
2020-03-04 17:49 ` [PATCH v5 14/14] KVM: selftests: Add "-c" parameter to dirty log test Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200309213554.GF4206@xz-x1 \
--to=peterx@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=dgilbert@redhat.com \
--cc=dinechin@redhat.com \
--cc=jasowang@redhat.com \
--cc=kbuild-all@lists.01.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=lei.cao@stratus.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=vkuznets@redhat.com \
--cc=yan.y.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox