Re: [PATCH 4.9 62/88] x86/boot/compressed: Dont declare __force_order in kaslr_64.c

Borislav Petkov
2020-03-10T15:08:44Z

On Tue, Mar 10, 2020 at 03:33:57PM +0100, Thomas Voegtle wrote:
> This ends up for me in:
>
> arch/x86/boot/compressed/pagetable.o: In function
> `initialize_identity_maps':
> pagetable.c:(.text+0x309): undefined reference to `__force_order'
> arch/x86/boot/compressed/pagetable.o: In function `finalize_identity_maps':
> pagetable.c:(.text+0x41a): undefined reference to `__force_order'
>
>
> pgtable_64.c doesn't exist in v4.9 for x86.
>
> So I guess it's not correct to remove __force_order from pagetable.c?

Yes, the second __force_order thing was added by

08529078d8d9 ("x86/boot/compressed/64: Detect and handle 5-level paging at boot-time")

which is 4.14.

Greg, pls drop this patch from the 4.9 lineup.

Thx.

--
Regards/Gruss,
Boris.

SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg