From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A9F5C10F27 for ; Tue, 10 Mar 2020 14:19:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 21C04205C9 for ; Tue, 10 Mar 2020 14:19:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Fj0crWzx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727467AbgCJOTH (ORCPT ); Tue, 10 Mar 2020 10:19:07 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:36450 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726992AbgCJOTH (ORCPT ); Tue, 10 Mar 2020 10:19:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583849946; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CLT2RA5SUURWmsLjASg70cp/vjsXgOMPTwKZtH6acFQ=; b=Fj0crWzxlMfA36XVFDttHR/Z3GoLv7ntFCjuLbMLSbko8ho7axYsUiEcO7DT916RYfRcRr Ol7KnkC0q09zP0hTIhgNXptTaBtyeOxwCRaR7QZ4U/s3XbD6SdDTPrGWV5GWQyM3h5rCWP 89KIhiKj700W8LYawq5J7YrQxIMrzNY= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-68-N7xN4eAGMd6vZMXqULVHhQ-1; Tue, 10 Mar 2020 10:19:05 -0400 X-MC-Unique: N7xN4eAGMd6vZMXqULVHhQ-1 Received: by mail-qk1-f199.google.com with SMTP id z124so9776566qkd.20 for ; Tue, 10 Mar 2020 07:19:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=CLT2RA5SUURWmsLjASg70cp/vjsXgOMPTwKZtH6acFQ=; b=A6t9gs2+zwt2PR9P78jGwOlnCL35LXEQOMVJzX/Eh+3OKXoRLTR4qI5PnJ8404U6td gQ30cV9mGT4c32/wkjrVFcdBHwVow25V/e5pyoyRDn2HE6yPDZioorQ16IyMTs9TNS2p uZH1eQqYBquJv9+hHiEXiMwMch71GXG+n7MObXRaiVgRv4mQ7wnTTe3Lj/mrP05LEElu L/XMKjAP0mhmtv7gXYEfd5MhkEY1RC/J3LNHYkXC6qSxxlfXTI8pUBYTl1+8wRmH9GXJ sD0NsGWGi5UODyYQYXExlFUG0qalHpdWGUoDmMnKRNdoQ/l5fu0+OuO5XjDXDHwKbZyA N5bw== X-Gm-Message-State: ANhLgQ3MORdLVaxbxqNidYaD170pUor/gyMv+q+3DeeJvT4qlI224VFk E7KcmBqrxzk8P7SGR4YBF3MkyO4ffSC/Ne1E2YZNPZQOKG9RmGGMdUG22Y84zmmOWmJwRjig6na s+FW7s8Qa8Ym9xIN7w6A548oU X-Received: by 2002:ac8:24ee:: with SMTP id t43mr19370541qtt.5.1583849944546; Tue, 10 Mar 2020 07:19:04 -0700 (PDT) X-Google-Smtp-Source: ADFU+vvbLInUYGyyBaSkTuX8MpCYO9twVHQpnHtWU2LMTP/RRdtqsEsL8hRnvWZPpPKEbp/TBnoJRA== X-Received: by 2002:ac8:24ee:: with SMTP id t43mr19370525qtt.5.1583849944291; Tue, 10 Mar 2020 07:19:04 -0700 (PDT) Received: from xz-x1 ([2607:9880:19c0:32::2]) by smtp.gmail.com with ESMTPSA id w13sm17099618qtn.83.2020.03.10.07.19.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2020 07:19:03 -0700 (PDT) Date: Tue, 10 Mar 2020 10:19:01 -0400 From: Peter Xu To: "Michael S. Tsirkin" Cc: kbuild test robot , kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Yan Zhao , Vitaly Kuznetsov , Alex Williamson , Sean Christopherson , "Dr . David Alan Gilbert" , Jason Wang , Kevin Tian , Paolo Bonzini , Christophe de Dinechin , Lei Cao Subject: Re: [PATCH v5 05/14] KVM: X86: Implement ring-based dirty memory tracking Message-ID: <20200310141901.GE326977@xz-x1> References: <20200304174947.69595-6-peterx@redhat.com> <202003061911.MfG74mgX%lkp@intel.com> <20200309213554.GF4206@xz-x1> <20200310022931-mutt-send-email-mst@kernel.org> <20200310140921.GD326977@xz-x1> <20200310101039-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200310101039-mutt-send-email-mst@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 10, 2020 at 10:11:30AM -0400, Michael S. Tsirkin wrote: > On Tue, Mar 10, 2020 at 10:09:21AM -0400, Peter Xu wrote: > > On Tue, Mar 10, 2020 at 02:31:55AM -0400, Michael S. Tsirkin wrote: > > > On Mon, Mar 09, 2020 at 05:35:54PM -0400, Peter Xu wrote: > > > > I'll probably also > > > > move KVM_DIRTY_LOG_PAGE_OFFSET==0 definition to uapi/linux/kvm.h. > > > > > > > > > IMHO KVM_DIRTY_LOG_PAGE_OFFSET is kind of pointless anyway - > > > we won't be able to move data around just by changing the > > > uapi value since userspace isn't > > > recompiled when kernel changes ... > > > > Yes I think we can even drop this KVM_DIRTY_LOG_PAGE_OFFSET==0 > > definition. IMHO it's only a matter of whether we would like to > > directly reference this value in the common code (e.g., for kernel > > virt/kvm_main.c) or we want quite a few of this instead: > > > > #ifdef KVM_DIRTY_LOG_PAGE_OFFSET > > .. > > #endif > > Hmm do other arches define it to a different value? > Maybe I'm confused. > If they do then it makes sense. Yes they can. So far with this series only x86 will define it to nonzero (64). But logically other archs can define it to different values. We can reference this to existing offsets that we've defined already for different archs, like KVM_COALESCED_MMIO_PAGE_OFFSET: - For ppc, it's defined as 1 (arch/powerpc/include/uapi/asm/kvm.h) - For x86, it's defined as 2 (arch/x86/include/uapi/asm/kvm.h) - ... Thanks, > > > I slightly prefer to not use lots of "#ifdef"s so I chose to make sure > > it's defined. However I've no strong opinion on this either. So I'm > > open to change that if anyone insists with some reasons. > > > > Thanks, > > > > -- > > Peter Xu > -- Peter Xu