From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 676BCC18E5B for ; Tue, 10 Mar 2020 14:35:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3734C20873 for ; Tue, 10 Mar 2020 14:35:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583850931; bh=k1Jmh1mF45Az4qy5EA2b77ScxjiPXg3Oimi/DWX6EnE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=pNU1YH4Ka2mPpx/p/nBDNtSWwXaNgjmMYE9ooFfKouE/X7f1v6sQ5F9/bnkB3+vgC o99tFlk9FGrkpltyCuu0p5f9U03sn2xpUKjWFfxhWjPttjhiArvrd1BS/xhZ6EMtaS mr1kU+yT8Pmd2xEIF5Vu0Z3EN8kF/d8wLSsJij0o= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727212AbgCJOfa (ORCPT ); Tue, 10 Mar 2020 10:35:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:59330 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726391AbgCJOfa (ORCPT ); Tue, 10 Mar 2020 10:35:30 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EE58620637; Tue, 10 Mar 2020 14:35:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583850929; bh=k1Jmh1mF45Az4qy5EA2b77ScxjiPXg3Oimi/DWX6EnE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Po3DDysw9JJoGJm9X7ToM5fdhDN56GnRTNwjGmwkkbPWOLQlh3vmaONK7V6er5LpB hbLRguaDfu1frr9oaUsYz15NLuSmzdTYH2Sbt8qiDTZeTIcfkHF0MH84JRBUpZOBp2 tYsZjl1qIoB9xKc9B+WEw7emwsDzI1he2HnhYcNY= Date: Tue, 10 Mar 2020 15:35:27 +0100 From: Greg Kroah-Hartman To: Holger =?iso-8859-1?Q?Hoffst=E4tte?= Cc: linux-kernel@vger.kernel.org, linux@roeck-us.net, shuah@kernel.org, stable@vger.kernel.org, Paolo Valente Subject: Re: [PATCH 5.4 000/168] 5.4.25-stable review Message-ID: <20200310143527.GB3376131@kroah.com> References: <20200310123635.322799692@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 10, 2020 at 03:02:37PM +0100, Holger Hoffstätte wrote: > On 3/10/20 1:37 PM, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 5.4.25 release. > > This fails to compile due to broken patch 001/168: > "block, bfq: get a ref to a group when adding it to a service tree": > > .. > block/bfq-wf2q.c: In function 'bfq_get_entity': > ./include/linux/kernel.h:994:51: error: 'struct bfq_group' has no member named 'entity' > .. > > The calls to bfq_get_entity::bfqg_and_blkg_get and bfq_forget_entity::bfqg_and_blkg_put > in bfq-wf2q.c need to be wrapped in #ifdef CONFIG_BFQ_GROUP_IOSCHED, otherwise > the build will fail when CONFIG_BFQ_GROUP_IOSCHED is not enabled. > This horribly error-prone #ifdef mess was finally removed in upstream commit > 4d8340d0d4d9. For 5.4 we'll either need that as well or add them back. Ick, that's a mess. I'll go drop that patch now, odd that it passed my build tests... thanks, greg k-h