From: Christoph Hellwig <hch@lst.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
iommu@lists.linux-foundation.org, aros@gmx.com
Subject: Re: [Bug 206175] Fedora >= 5.4 kernels instantly freeze on boot without producing any display output
Date: Tue, 10 Mar 2020 19:25:46 +0100 [thread overview]
Message-ID: <20200310182546.GA9268@lst.de> (raw)
In-Reply-To: <CAHk-=wgB2YMM6kw8W0wq=7efxsRERL14OHMOLU=Nd1OaR+sXvw@mail.gmail.com>
FYI, Linus' latest rant shows up in bugzilla, but never made it to me,
just as the other replies from Artem and Hans. This just shows how
broken bugzilla is as a reporting tool. Please be a little more calm,
I've always taken reported regressions series and as a first priority,
but it really does not help if information is hidden away. Adding
Artem to the Cc list and drop bugzilla to make this work a bit better.
Artem, can you test the patch below? This fixes the broken dma_mask
handling in platform_device_register_full that could override a
perfectly valid mask with 0. If this doesn't work, can you throw
in a dump_stack() into the working kernel build to see where
platform_device_register_full and setup_pdev_dma_masks get called
for your system?
diff --git a/drivers/base/platform.c b/drivers/base/platform.c
index 7fa654f1288b..03035661eb6b 100644
--- a/drivers/base/platform.c
+++ b/drivers/base/platform.c
@@ -662,19 +662,6 @@ struct platform_device *platform_device_register_full(
pdev->dev.of_node_reused = pdevinfo->of_node_reused;
if (pdevinfo->dma_mask) {
- /*
- * This memory isn't freed when the device is put,
- * I don't have a nice idea for that though. Conceptually
- * dma_mask in struct device should not be a pointer.
- * See http://thread.gmane.org/gmane.linux.kernel.pci/9081
- */
- pdev->dev.dma_mask =
- kmalloc(sizeof(*pdev->dev.dma_mask), GFP_KERNEL);
- if (!pdev->dev.dma_mask)
- goto err;
-
- kmemleak_ignore(pdev->dev.dma_mask);
-
*pdev->dev.dma_mask = pdevinfo->dma_mask;
pdev->dev.coherent_dma_mask = pdevinfo->dma_mask;
}
next parent reply other threads:[~2020-03-10 18:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-206175-5873@https.bugzilla.kernel.org/>
[not found] ` <bug-206175-5873-S6PaNNClEr@https.bugzilla.kernel.org/>
[not found] ` <CAHk-=wi4GS05j67V0D_cRXRQ=_Jh-NT0OuNpF-JFsDFj7jZK9A@mail.gmail.com>
[not found] ` <20200310162342.GA4483@lst.de>
[not found] ` <CAHk-=wgB2YMM6kw8W0wq=7efxsRERL14OHMOLU=Nd1OaR+sXvw@mail.gmail.com>
2020-03-10 18:25 ` Christoph Hellwig [this message]
2020-03-11 15:24 ` [Bug 206175] Fedora >= 5.4 kernels instantly freeze on boot without producing any display output Christoph Hellwig
2020-03-11 15:34 ` Artem S. Tashkinov
2020-03-11 15:43 ` Christoph Hellwig
2020-03-11 15:47 ` Christoph Hellwig
2020-03-11 16:02 ` Artem S. Tashkinov
2020-03-11 16:15 ` Robin Murphy
2020-03-11 16:21 ` Linus Torvalds
2020-03-11 16:24 ` Linus Torvalds
2020-03-11 16:48 ` Linus Torvalds
2020-03-11 17:05 ` Artem S. Tashkinov
2020-03-11 17:21 ` Artem S. Tashkinov
2020-03-11 17:27 ` Linus Torvalds
2020-03-11 15:48 ` Artem S. Tashkinov
2020-03-11 15:57 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200310182546.GA9268@lst.de \
--to=hch@lst.de \
--cc=aros@gmx.com \
--cc=gregkh@linuxfoundation.org \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox