From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3C70C10DCE for ; Tue, 10 Mar 2020 22:25:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 665D1222C3 for ; Tue, 10 Mar 2020 22:25:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="kXz7Nuyq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727899AbgCJWZq (ORCPT ); Tue, 10 Mar 2020 18:25:46 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:38005 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727770AbgCJWZp (ORCPT ); Tue, 10 Mar 2020 18:25:45 -0400 Received: by mail-pf1-f193.google.com with SMTP id z5so142246pfn.5 for ; Tue, 10 Mar 2020 15:25:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+SMw3KzwW0qIsxOajP3cV8dZM1F0dvmhCHxZU/Nkvn4=; b=kXz7NuyqUXk06IqGmoTk11IMzDW5AzrbJi35Fg7DHg8FyMNbD2e7cBObxGFy6GQFaZ dbNZPDzIsV9c6hMAlwZKh4x5bUKzT0J7VK/vU68bKIga53ppfumHvMB5M7I9GByTA+E0 usgCHNvznKWBrJNV+rJDfZjjITw4IHL+w5b86vHZ8EhxRJnCyFJCGMHuJvrlFaTY2Fvv o2lIdi4kOS1rtjP7m8kRlSBig0jyNKN3ISii8t4Iv1RSoyNziWIZvqJG1OdTckQX2LN/ IGer/J6Jg9aoAZPgRZcw0PbwTw7bNUHUATwHip1aKHSA2JlD9GvveB7fJDj+RESHDNTV q2wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+SMw3KzwW0qIsxOajP3cV8dZM1F0dvmhCHxZU/Nkvn4=; b=dkwCGUxlzQ7TmN/n8gdf55KfogXWtVu+2700uE6nlc+OXMH05sJXd3pkLPTXGuvq2b UBTLoKXImLliE2ZM1FQ5i/atv88zlRdSWxMJOEXCWAr7JXf3i9QTqFYJrDavd/klrYVj +quHsjpqTYN+wjZx50D1xautnCrFflLkR4Szmvx5MzgNvJfE3ah6bi4uCnf00nVfBvd+ 7X5H4Xb91zfqfjOo/v7xGf4cvMOdjsac51DyrgLl818p3iUXQYYG17seUZWMJme6yuJ/ 5Yypq4FRfZzSCeRbAmdmwEcGFWRzgTx2bmcH8sYiEb607CFq/lV7wxmtm9IVDiv0Xpbv 31Rw== X-Gm-Message-State: ANhLgQ0npJerwerdAUY6WHYLOjlTCQynHfR1gVfqYbOHVfgApnwtwBqv R1hgkcfBrmYkS9YlIAeVftlVSQ== X-Google-Smtp-Source: ADFU+vsP3GEkD/yGCbjWZr9amUrSp8lGkyIkcahbLxq5xe/LUQjUc2fdKy0+00IllBQ6HMvbgl29QA== X-Received: by 2002:a65:5905:: with SMTP id f5mr21428215pgu.87.1583879144413; Tue, 10 Mar 2020 15:25:44 -0700 (PDT) Received: from builder (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id q9sm47191418pgs.89.2020.03.10.15.25.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2020 15:25:43 -0700 (PDT) Date: Tue, 10 Mar 2020 15:25:41 -0700 From: Bjorn Andersson To: Nathan Chancellor Cc: Ohad Ben-Cohen , linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com Subject: Re: [PATCH] remoteproc/mediatek: Use size_t type for len in scp_da_to_va Message-ID: <20200310222541.GG14744@builder> References: <20200310211514.32288-1-natechancellor@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200310211514.32288-1-natechancellor@gmail.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 10 Mar 14:15 PDT 2020, Nathan Chancellor wrote: > Clang errors: > > drivers/remoteproc/mtk_scp.c:364:14: error: incompatible function > pointer types initializing 'void *(*)(struct rproc *, u64, size_t)' (aka > 'void *(*)(struct rproc *, unsigned long long, unsigned int)') with an > expression of type 'void *(struct rproc *, u64, int)' (aka 'void > *(struct rproc *, unsigned long long, int)') > [-Werror,-Wincompatible-function-pointer-types] > .da_to_va = scp_da_to_va, > ^~~~~~~~~~~~ > 1 error generated. > > Make the same change as commit 0fcbb369f052 ("remoteproc: Use size_t > type for len in da_to_va"), which was not updated for the acceptance of > commit 63c13d61eafe ("remoteproc/mediatek: add SCP support for mt8183"). > > Fixes: 0fcbb369f052 ("remoteproc: Use size_t type for len in da_to_va") > Link: https://github.com/ClangBuiltLinux/linux/issues/927 > Signed-off-by: Nathan Chancellor Applied, thank you. Regards, Bjorn > --- > drivers/remoteproc/mtk_scp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c > index 7ccdf64ff3ea..ea3743e7e794 100644 > --- a/drivers/remoteproc/mtk_scp.c > +++ b/drivers/remoteproc/mtk_scp.c > @@ -320,7 +320,7 @@ static int scp_start(struct rproc *rproc) > return ret; > } > > -static void *scp_da_to_va(struct rproc *rproc, u64 da, int len) > +static void *scp_da_to_va(struct rproc *rproc, u64 da, size_t len) > { > struct mtk_scp *scp = (struct mtk_scp *)rproc->priv; > int offset; > -- > 2.26.0.rc1 >