From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BABBC0044D for ; Wed, 11 Mar 2020 17:20:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8AD5B20736 for ; Wed, 11 Mar 2020 17:20:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="LIlHm+ed" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730424AbgCKRUZ (ORCPT ); Wed, 11 Mar 2020 13:20:25 -0400 Received: from mail-pl1-f193.google.com ([209.85.214.193]:43023 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730211AbgCKRUZ (ORCPT ); Wed, 11 Mar 2020 13:20:25 -0400 Received: by mail-pl1-f193.google.com with SMTP id f8so1391358plt.10 for ; Wed, 11 Mar 2020 10:20:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=P6EKaX1yk36UPbpCr2MJbOIatu0Z5wCwvN3X/nog/c4=; b=LIlHm+edvk5lAktjIoXzhtiMe7TTT/WwRCOMvZQCRPYaM69mTOO4DszMDJXXb9PdZZ ob6Qobrw3w6Ag6uVvMMeXLqv/UlP2LWjlRzi95wn7vhHMu4GxIGYERXnK+nXSZ+cccTO 9igVbvTcDlKDU1TbWaTuP5QwiMLQtZdaWIC78= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=P6EKaX1yk36UPbpCr2MJbOIatu0Z5wCwvN3X/nog/c4=; b=CsR1kEx7yTWIorRszEBggyXI0fAHTaMTKWnX5U8M4GbrEcF0tbKH5vajG43SFzR8xX YDR6q3vcVjp5XofspvjFN6uo+e8M/bnNDE6sI+ka2vZ1IqUQwNzJ+y0VEvtrmh0JQbGP Gju7mbadPn+xki/v7vmKvCoo5u9Loe4R+6soB40FTVYj3ywQQNLQ44zv4AnvgdoJH5e3 Cu5Mmvd4Itmvd2eYD+wir1RB1U3b7sCXh85y7ia6WtmjXQ/qJTMAmjkRgKkUjEE8Wgrq KRvN5GjHMrfbLvW84YWZ4AXqmtWjVnZLxG41FO74haARDUHyisuyPq0brLOM9uIPktsa OQFg== X-Gm-Message-State: ANhLgQ2K6TTIcSINv6vuWji9ZixTwrjf3Tyqpktt/YNU/C6ovg9ZdFK6 BxAOT89f50cLvNgH/d9v6M982w== X-Google-Smtp-Source: ADFU+vv/0NCgP3hBuxLBflFF34xjIGPeo/MBF1uHeyjSSzOUs4fjmSmfzp3rj/UTad09GD08/7v+/Q== X-Received: by 2002:a17:90a:cb90:: with SMTP id a16mr1689261pju.80.1583947224699; Wed, 11 Mar 2020 10:20:24 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id v123sm24901012pfb.85.2020.03.11.10.20.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2020 10:20:23 -0700 (PDT) Date: Wed, 11 Mar 2020 10:20:22 -0700 From: Kees Cook To: Andrew Morton Cc: Alexander Viro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fs_parse: Remove pr_notice() about each validation Message-ID: <202003111015.E263BE9448@keescook> References: <202003061617.A8835CAAF@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202003061617.A8835CAAF@keescook> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andrew, Can you pick this up in -mm? Thanks! -Kees On Fri, Mar 06, 2020 at 04:20:02PM -0800, Kees Cook wrote: > This notice fills my boot logs with scary-looking asterisks but doesn't > really tell me anything. Let's just remove it; validation errors > are already reported separately, so this is just a redundant list of > filesystems. > > $ dmesg | grep VALIDATE > [ 0.306256] *** VALIDATE tmpfs *** > [ 0.307422] *** VALIDATE proc *** > [ 0.308355] *** VALIDATE cgroup *** > [ 0.308741] *** VALIDATE cgroup2 *** > [ 0.813256] *** VALIDATE bpf *** > [ 0.815272] *** VALIDATE ramfs *** > [ 0.815665] *** VALIDATE hugetlbfs *** > [ 0.876970] *** VALIDATE nfs *** > [ 0.877383] *** VALIDATE nfs4 *** > > Signed-off-by: Kees Cook > --- > fs/fs_parser.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fs/fs_parser.c b/fs/fs_parser.c > index 7e6fb43f9541..ab53e42a874a 100644 > --- a/fs/fs_parser.c > +++ b/fs/fs_parser.c > @@ -368,8 +368,6 @@ bool fs_validate_description(const char *name, > const struct fs_parameter_spec *param, *p2; > bool good = true; > > - pr_notice("*** VALIDATE %s ***\n", name); > - > for (param = desc; param->name; param++) { > /* Check for duplicate parameter names */ > for (p2 = desc; p2 < param; p2++) { > -- > 2.20.1 > > > -- > Kees Cook -- Kees Cook