Re: [PATCH v2 3/5] exec: Move cleanup of posix timers on exec out of de_thread

Bernd Edlinger
2020-03-09T19:30:59Z

On 3/8/20 10:36 PM, Eric W. Biederman wrote:
>
> These functions have very little to do with de_thread move them out
> of de_thread an into flush_old_exec proper so it can be more clearly
> seen what flush_old_exec is doing.
>
> Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>

Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de>

Bernd.
> ---
> fs/exec.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/fs/exec.c b/fs/exec.c
> index ff74b9a74d34..215d86f77b63 100644
> --- a/fs/exec.c
> +++ b/fs/exec.c
> @@ -1189,11 +1189,6 @@ static int de_thread(struct task_struct *tsk)
> /* we have changed execution domain */
> tsk->exit_signal = SIGCHLD;
>
> -#ifdef CONFIG_POSIX_TIMERS
> - exit_itimers(sig);
> - flush_itimer_signals();
> -#endif
> -
> BUG_ON(!thread_group_leader(tsk));
> return 0;
>
> @@ -1277,6 +1272,11 @@ int flush_old_exec(struct linux_binprm * bprm)
> if (retval)
> goto out;
>
> +#ifdef CONFIG_POSIX_TIMERS
> + exit_itimers(me->signal);
> + flush_itimer_signals();
> +#endif
> +
> /*
> * Make the signal table private.
> */
>