Re: [PATCH 4/4] kernel: doc: remove outdated comment cred.c

Kees Cook
2020-03-11T18:54:09Z

On Tue, Mar 10, 2020 at 02:44:18PM +0100, Bernd Edlinger wrote:
> This removes an outdated comment in prepare_kernel_cred.
>
> There is no "cred_replace_mutex" any more, so the comment must
> go away.
>
> Signed-off-by: Bernd Edlinger <bernd.edlinger@hotmail.de>

Reviewed-by: Kees Cook <keescook@chromium.org>

-Kees

> ---
> kernel/cred.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/kernel/cred.c b/kernel/cred.c
> index 809a985..71a7926 100644
> --- a/kernel/cred.c
> +++ b/kernel/cred.c
> @@ -675,8 +675,6 @@ void __init cred_init(void)
> * The caller may change these controls afterwards if desired.
> *
> * Returns the new credentials or NULL if out of memory.
> - *
> - * Does not take, and does not return holding current->cred_replace_mutex.
> */
> struct cred *prepare_kernel_cred(struct task_struct *daemon)
> {
> --
> 1.9.1

--
Kees Cook