Re: [RFC][PATCH 05/16] objtool: Optimize find_symbol_by_index()

Peter Zijlstra
2020-03-17T14:08:39Z

On Tue, Mar 17, 2020 at 12:55:01PM +0100, Miroslav Benes wrote:
> > --- a/tools/objtool/elf.h
> > +++ b/tools/objtool/elf.h
> > @@ -27,7 +27,6 @@ struct section {
> > struct list_head list;
> > GElf_Shdr sh;
> > struct list_head symbol_list;
> > - DECLARE_HASHTABLE(symbol_hash, 8);
> > struct list_head rela_list;
> > DECLARE_HASHTABLE(rela_hash, 16);
> > struct section *base, *rela;
> > @@ -71,7 +70,7 @@ struct elf {
> > int fd;
> > char *name;
> > struct list_head sections;
> > - DECLARE_HASHTABLE(rela_hash, 16);
> > + DECLARE_HASHTABLE(symbol_hash, 20);
> > };
>
> Not that it really matters, but what was rela_hash in struct elf for
> before this?

Unused afaict.