Re: [PATCH v2 2/4] dt-bindings: bus: Add Baikal-T1 APB-bus binding

Rob Herring
2020-05-15T03:14:02Z

On Fri, 8 May 2020 01:41:14 +0300, Serge Semin wrote:
> Baikal-T1 CPU or DMAC MMIO requests are handled by the AMBA 3 AXI
> Interconnect which routes them to the AXI-APB bridge, which in turn
> serializes accesses and routes them to the corresponding APB slave device.
> This binding describes the AXI-APB bridge considered as the APB-bus. It is
> supposed to be compatible with "be,bt1-apb" and "simple-bus" drivers,
> should be equipped with EHB MMIO region and a region with no slave device
> mapped, interrupts line number, APB reference clock and domain reset line.
>
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> Cc: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>
> Cc: Paul Burton <paulburton@kernel.org>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Tero Kristo <t-kristo@ti.com>
> Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> Cc: Jeffrey Hugo <jhugo@codeaurora.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Olof Johansson <olof@lixom.net>
> Cc: linux-mips@vger.kernel.org
> Cc: soc@kernel.org
>
> ---
>
> Rob, I had to remove your Reviewed-by tag, since new changes had been
> introduced.
>
> Changelog v2:
> - Move driver to the bus subsystem.
> - Don't use a multi-arg clock phandle reference in the examples dt-bindings
> property. Thus redundant include statement can be removed.
> - Use dual GPL/BSD license.
> - Use single lined copyright header.
> - Lowercase the unit-address.
> - Convert a dedicated EHB block binding to the Baikal-T1 APB-bus one.
> - Add APB reference clock and reset support.
> - Replace "additionalProperties: false" property with
> "unevaluatedProperties: false".
> - Add reg-names property.
> ---
> .../bindings/bus/baikal,bt1-apb.yaml | 90 +++++++++++++++++++
> 1 file changed, 90 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/bus/baikal,bt1-apb.yaml
>

Reviewed-by: Rob Herring <robh@kernel.org>