From: Mark Brown <broonie@kernel.org>
To: Peter Chen <peter.chen@nxp.com>
Cc: "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH 1/1] regulator: fixed: add system pm routines for pinctrl
Date: Fri, 13 Mar 2020 12:11:03 +0000 [thread overview]
Message-ID: <20200313121103.GD5528@sirena.org.uk> (raw)
In-Reply-To: <20200313030851.GI14625@b29397-desktop>
[-- Attachment #1: Type: text/plain, Size: 687 bytes --]
On Fri, Mar 13, 2020 at 03:08:48AM +0000, Peter Chen wrote:
> On 20-03-12 15:07:10, Mark Brown wrote:
> > I'd expect that this would be handled by the GPIO driver, the user
> > shouldn't need to care.
> GPIO function is just our case for this fixed regulator, other users for
> this fixed regulator may set pinctrl as other functions.
> Here, it is just save and restore pinctrl value for fixed regulator
> driver, not related to GPIO.
My point is that the fixed regulator doesn't have pins in pinctrl,
whatever is providing the control signal to the fixed voltage regulator
(if there is one) does. I'd expect this to be being handled on the
producer side rather than the consumer.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-03-13 12:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 10:38 [PATCH 1/1] regulator: fixed: add system pm routines for pinctrl Peter Chen
2020-03-12 11:47 ` Mark Brown
2020-03-12 13:00 ` Peter Chen
2020-03-12 14:37 ` Mark Brown
2020-03-12 15:03 ` Peter Chen
2020-03-12 15:07 ` Mark Brown
2020-03-13 3:08 ` Peter Chen
2020-03-13 12:11 ` Mark Brown [this message]
2020-03-13 13:16 ` Peter Chen
2020-03-13 13:29 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200313121103.GD5528@sirena.org.uk \
--to=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.chen@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox