From: afzal mohammed <afzal.mohd.ma@gmail.com>
To: Guan Xuetao <gxt@pku.edu.cn>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] unicore32: replace setup_irq() by request_irq()
Date: Fri, 13 Mar 2020 18:15:22 +0530 [thread overview]
Message-ID: <20200313124522.GC7225@afzalpc> (raw)
In-Reply-To: <20200304005137.5523-1-afzal.mohd.ma@gmail.com>
Hi Guan Xuetao,
On Wed, Mar 04, 2020 at 06:21:37AM +0530, afzal mohammed wrote:
> request_irq() is preferred over setup_irq(). Invocations of setup_irq()
> occur after memory allocators are ready.
>
> Per tglx[1], setup_irq() existed in olden days when allocators were not
> ready by the time early interrupts were initialized.
>
> Hence replace setup_irq() by request_irq().
>
> [1] https://lkml.kernel.org/r/alpine.DEB.2.20.1710191609480.1971@nanos
>
> Signed-off-by: afzal mohammed <afzal.mohd.ma@gmail.com>
> ---
> Hi unicorn maintainers,
>
> if okay w/ this change, please consider taking it thr' your tree, else please
> let me know.
i have not seen any recent pull request from you for unicore32, if
this patch is okay, please consider ack-ing this so as to take via
tglx.
Regards
afzal
prev parent reply other threads:[~2020-03-13 12:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 0:51 [PATCH v3] unicore32: replace setup_irq() by request_irq() afzal mohammed
2020-03-13 12:45 ` afzal mohammed [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200313124522.GC7225@afzalpc \
--to=afzal.mohd.ma@gmail.com \
--cc=gxt@pku.edu.cn \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox