Re: [PATCH v4 1/2] dt-bindings: display: Add idk-1110wr binding

Sam Ravnborg
2020-03-15T02:26:59Z

Hi Prabhakar

On Wed, Mar 11, 2020 at 08:03:39PM +0000, Lad Prabhakar wrote:
> From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
>
> Add binding for the idk-1110wr LVDS panel from Advantech.
>
> Some panel-specific documentation can be found here:
> https://buy.advantech.eu/Displays/Embedded-LCD-Kits-LCD-Kit-Modules/model-IDK-1110WR-55WSA1E.htm
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Applied, and pushed to drm-misc-next.

Sam

> ---
> .../display/panel/advantech,idk-1110wr.yaml | 69 ++++++++++++++++++++++
> 1 file changed, 69 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/advantech,idk-1110wr.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/panel/advantech,idk-1110wr.yaml b/Documentation/devicetree/bindings/display/panel/advantech,idk-1110wr.yaml
> new file mode 100644
> index 0000000..93878c2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/advantech,idk-1110wr.yaml
> @@ -0,0 +1,69 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/advantech,idk-1110wr.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Advantech IDK-1110WR 10.1" WSVGA LVDS Display Panel
> +
> +maintainers:
> + - Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> + - Thierry Reding <thierry.reding@gmail.com>
> +
> +allOf:
> + - $ref: lvds.yaml#
> +
> +properties:
> + compatible:
> + items:
> + - const: advantech,idk-1110wr
> + - {} # panel-lvds, but not listed here to avoid false select
> +
> + data-mapping:
> + const: jeida-24
> +
> + width-mm:
> + const: 223
> +
> + height-mm:
> + const: 125
> +
> + panel-timing: true
> + port: true
> +
> +additionalProperties: false
> +
> +required:
> + - compatible
> +
> +examples:
> + - |+
> + panel {
> + compatible = "advantech,idk-1110wr", "panel-lvds";
> +
> + width-mm = <223>;
> + height-mm = <125>;
> +
> + data-mapping = "jeida-24";
> +
> + panel-timing {
> + /* 1024x600 @60Hz */
> + clock-frequency = <51200000>;
> + hactive = <1024>;
> + vactive = <600>;
> + hsync-len = <240>;
> + hfront-porch = <40>;
> + hback-porch = <40>;
> + vsync-len = <10>;
> + vfront-porch = <15>;
> + vback-porch = <10>;
> + };
> +
> + port {
> + panel_in: endpoint {
> + remote-endpoint = <&lvds_encoder>;
> + };
> + };
> + };
> +
> +...
> --
> 2.7.4