From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DATE_IN_PAST_03_06, DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3BF1C1975A for ; Sun, 15 Mar 2020 01:54:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A6288206D5 for ; Sun, 15 Mar 2020 01:54:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="qthyx8aP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727642AbgCOBy0 (ORCPT ); Sat, 14 Mar 2020 21:54:26 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:36040 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727604AbgCOByY (ORCPT ); Sat, 14 Mar 2020 21:54:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=34FCefzXq9jcpy6xxlY5FvhoT4tmrorgyUO2Eh1b8GQ=; b=qthyx8aPypDZfsWdTrFz4XDR6U AYRfUhBbKjJMIAfDrRXnnn/NdYy35juxywDbnsY73Zos0LFuOW6CNrM5s4m4P86SznWgiWvcxi9PL Jfl5sXz3QWoKUv1GKoY/s3EileOCJYLBjZj6g5BK39v2XKtW+AndBrbCjSGpeBo8pylw=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1jDEBJ-0002KN-Dk; Sat, 14 Mar 2020 22:18:53 +0100 Date: Sat, 14 Mar 2020 22:18:53 +0100 From: Andrew Lunn To: Madalin Bucur Cc: davem@davemloft.net, netdev@vger.kernel.org, devicetree@vger.kernel.org, shawnguo@kernel.org, leoyang.li@nxp.com, robh+dt@kernel.org, mark.rutland@arm.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net 2/3] arm64: dts: ls1043a-rdb: correct RGMII delay mode to rgmii-id Message-ID: <20200314211853.GB8622@lunn.ch> References: <1584101065-3482-1-git-send-email-madalin.bucur@oss.nxp.com> <1584101065-3482-3-git-send-email-madalin.bucur@oss.nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1584101065-3482-3-git-send-email-madalin.bucur@oss.nxp.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 13, 2020 at 02:04:24PM +0200, Madalin Bucur wrote: > The correct setting for the RGMII ports on LS1043ARDB is to > enable delay on both Rx and Tx so the interface mode used must > be PHY_INTERFACE_MODE_RGMII_ID. > > Since commit 1b3047b5208a80 ("net: phy: realtek: add support for > configuring the RX delay on RTL8211F") the Realtek 8211F PHY driver > has control over the RGMII RX delay and it is disabling it for > RGMII_TXID. The LS1043ARDB uses two such PHYs in RGMII_ID mode but > in the device tree the mode was described as "rgmii_txid". > This issue was not apparent at the time as the PHY driver took the > same action for RGMII_TXID and RGMII_ID back then but it became > visible (RX no longer working) after the above patch. > > Changing the phy-connection-type to "rgmii-id" to address the issue. > > Fixes: bf02f2ffe59c ("arm64: dts: add LS1043A DPAA FMan support") > Signed-off-by: Madalin Bucur Reviewed-by: Andrew Lunn Andrew