Re: [PATCHv6 2/3] mm/gup: fix omission of check on FOLL_LONGTERM in gup fast path

Pingfan Liu
2020-03-17T11:45:57Z

On Mon, Mar 16, 2020 at 4:55 PM Christoph Hellwig <hch@infradead.org> wrote:
>
[...]
>
> Wrong indentation. We either align two tabs for continuation
> statements, or after the opening brace of the previous line. With a
> likely or unlikely thrown in the former IMHO looks much better. E.g.
>
> if (unlikely(flags & FOLL_LONGTERM) &&
> is_migrate_cma_page(page))
> return NULL;
>
OK, thanks. I will send out V7 to fix it.

Regards,
Pingfan