From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DF15C2BB1D for ; Mon, 16 Mar 2020 10:01:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CE3E52071C for ; Mon, 16 Mar 2020 10:01:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="I1X2Qv5g" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730573AbgCPKBz (ORCPT ); Mon, 16 Mar 2020 06:01:55 -0400 Received: from mail.skyhub.de ([5.9.137.197]:38530 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730558AbgCPKBx (ORCPT ); Mon, 16 Mar 2020 06:01:53 -0400 Received: from zn.tnic (p200300EC2F06AB0069F33882ABEAD541.dip0.t-ipconnect.de [IPv6:2003:ec:2f06:ab00:69f3:3882:abea:d541]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 8A0C71EC0CC5; Mon, 16 Mar 2020 11:01:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1584352911; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=eo6Lnj2n6Gi2H5HDTW21SG50NWmPM4Kj2koyWSbmyHk=; b=I1X2Qv5g4XkDQqYw0Ot/gY9xVZEMZp9A8BVdRVlbUjBa8yWiz4CCunDQB6i+262pWm/OEO PffIe6vhAaI/VD5qH+s6VO+4I2Pt1n1bcJqAWvrNt/Lw1+ccNpGOW3WyhBmXaiOZiwGL1X A7wVN8cFLSC4qadSNKjbDI20tRyMaNU= Date: Mon, 16 Mar 2020 11:02:02 +0100 From: Borislav Petkov To: Jian-Hong Pan Cc: Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , Ard Biesheuvel , Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck , x86@kernel.org, Linux Kernel , linux-efi@vger.kernel.org, Linux Upstreaming Team Subject: Re: [PATCH] Revert "x86/reboot, efi: Use EFI reboot for Acer TravelMate X514-51T" Message-ID: <20200316100201.GG26126@zn.tnic> References: <20200312083341.9365-1-jian-hong@endlessm.com> <20200312104643.GA15619@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 16, 2020 at 05:17:56PM +0800, Jian-Hong Pan wrote: > But, that will raise another question: Since the original quirk works > for all Acer X514-51T and the quirk cannot be removed for older BIOS. > Why not keep only original matching items for all Acer X514-51T > laptops? What does the "original matching items" mean? > I am not sure which option is better. Any comment? If you mean, "let's not do anything and fix it only when there's really a need to fix anything", then yes, I agree. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette